Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend arithmetic operator traits over refs #64

Merged
merged 2 commits into from
Feb 7, 2022
Merged

Extend arithmetic operator traits over refs #64

merged 2 commits into from
Feb 7, 2022

Conversation

Chris00
Copy link
Contributor

@Chris00 Chris00 commented Dec 30, 2021

This is convenient and std does it for standard types.

@unageek
Copy link
Owner

unageek commented Jan 9, 2022

@Chris00 Could you investigate the Clippy errors?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1637422554

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.667%
Totals Coverage Status
Change from base Build 1591111864: 0.0%
Covered Lines: 2004
Relevant Lines: 2044
💛 - Coveralls

@Chris00
Copy link
Contributor Author

Chris00 commented Feb 7, 2022

@Chris00 Could you investigate the Clippy errors?

Done. They were about the #[must_use] attribute when returning Self.

@unageek
Copy link
Owner

unageek commented Feb 7, 2022

LGTM! Thank you so much!

@unageek unageek merged commit 8f6d26f into unageek:main Feb 7, 2022
@Chris00 Chris00 deleted the forward_ref branch February 7, 2022 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Chris00 @unageek @coveralls