Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate pown in favor of powi #70

Merged
merged 4 commits into from
Feb 8, 2022
Merged

Deprecate pown in favor of powi #70

merged 4 commits into from
Feb 8, 2022

Conversation

Chris00
Copy link
Contributor

@Chris00 Chris00 commented Feb 7, 2022

PR requested at #68

@coveralls
Copy link

coveralls commented Feb 7, 2022

Pull Request Test Coverage Report for Build 1808108803

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.667%

Totals Coverage Status
Change from base Build 1807691507: 0.0%
Covered Lines: 2004
Relevant Lines: 2044

💛 - Coveralls

unageek added a commit to unageek/ITF1788 that referenced this pull request Feb 7, 2022
@unageek
Copy link
Owner

unageek commented Feb 7, 2022

Could you update the git submodule ITF1788 in the root directory to point to the commit https://github.com/unageek/ITF1788/tree/00713f72703996192aabe13c5a21ffd1be4b531b?

Copy link
Owner

@unageek unageek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! Please check the comments.

tests/itf1788_tests/libieeep1788_elem.rs Outdated Show resolved Hide resolved
src/elementary.rs Outdated Show resolved Hide resolved
@Chris00 Chris00 force-pushed the master branch 2 times, most recently from 64b2ee3 to e96e881 Compare February 7, 2022 17:23
@Chris00
Copy link
Contributor Author

Chris00 commented Feb 7, 2022

Rebased on main.

@Chris00 Chris00 requested a review from unageek February 7, 2022 18:57
Copy link
Owner

@unageek unageek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

Could you address #70 (comment)?

@unageek unageek merged commit dd67a34 into unageek:main Feb 8, 2022
@unageek
Copy link
Owner

unageek commented Feb 8, 2022

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants