Update mimemagic to patched version #253
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rhian
approved these changes
Mar 24, 2021
kceb
reviewed
Mar 24, 2021
| @@ -178,7 +178,7 @@ GEM | |||
| marcel (0.3.3) | |||
| mimemagic (~> 0.3.2) | |||
|
Closing this, as the rails team is working on the apache based solution that should be available soon - so its best to wait for that instead of patching to the 0.3.7 (this one now released under MIT but apparently has some caveats) - rails/rails#41757 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Mimemagic 0.3.2 is broken. Latest patched version is 0.3.6 but that is now released under a GPL-2 license
mimemagicrb/mimemagic#98 (comment)
Rails maintainers are working on a replacement that uses MIT, but that is work in progress:
rails/rails#41751