Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create a console reporter #44

Merged
merged 6 commits into from
May 23, 2023
Merged

feat: Create a console reporter #44

merged 6 commits into from
May 23, 2023

Conversation

tarkatronic
Copy link
Contributor

Fixes #33

This is a quick win that helps prove out the new multi-reporter interface.

@tarkatronic tarkatronic requested a review from a team April 27, 2023 19:38
@phylum-io
Copy link

phylum-io bot commented Apr 27, 2023

Phylum OSS Supply Chain Risk Analysis - INCOMPLETE

The analysis contains 1 package(s) Phylum has not yet processed,
preventing a complete risk analysis. Phylum is processing these
packages currently and should complete soon.
Please wait for up to 30 minutes, then re-run the analysis.

View this project in the Phylum UI

@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Merging #44 (42d8a7c) into main (d9f2c25) will increase coverage by 4.07%.
The diff coverage is 90.24%.

@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
+ Coverage   44.00%   48.07%   +4.07%     
==========================================
  Files          12       13       +1     
  Lines         400      441      +41     
==========================================
+ Hits          176      212      +36     
- Misses        223      228       +5     
  Partials        1        1              
Flag Coverage Δ
unittests 48.07% <90.24%> (+4.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/scan.go 0.00% <0.00%> (ø)
reporting/console.go 92.50% <92.50%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

fix: Made the Config member of reporters public so it can be passed in
doc: Added a bit of documentation for the ConsoleReporter explaining its
     current state
feat: Added a console icon for the Maven ecosystem
@phylum-io
Copy link

phylum-io bot commented May 22, 2023

Phylum OSS Supply Chain Risk Analysis - SUCCESS

The Phylum risk analysis is complete and has passed the active policy.

View this project in the Phylum UI

@tarkatronic tarkatronic marked this pull request as ready for review May 22, 2023 22:29
@phylum-io
Copy link

phylum-io bot commented May 22, 2023

Phylum OSS Supply Chain Risk Analysis - INCOMPLETE

The analysis contains 6 package(s) Phylum has not yet processed,
preventing a complete risk analysis. Phylum is processing these
packages currently and should complete soon.
Please wait for up to 30 minutes, then re-run the analysis.

View this project in the Phylum UI

@phylum-io
Copy link

phylum-io bot commented May 22, 2023

Phylum OSS Supply Chain Risk Analysis - SUCCESS

The Phylum risk analysis is complete and has passed the active policy.

View this project in the Phylum UI

Copy link
Contributor

@JoseAngel1196 JoseAngel1196 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Would it be possible to include a screenshot showcasing the console report?

@tarkatronic tarkatronic merged commit 9b78d09 into main May 23, 2023
@tarkatronic tarkatronic deleted the feat/console-reporter branch May 23, 2023 14:50
@tarkatronic
Copy link
Contributor Author

Great! Would it be possible to include a screenshot showcasing the console report?

Oh yes great call, we will have to include screenshots in our docs. My struggle is, I don't want to show our own vulnerabilities 😂 Maybe we can set up some kind of dummy org. That could also help with integration tests. But that's a super far future thing. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a console reporter
2 participants