-
-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Remove system apps" breaks windows commulative updates #287
Comments
Hi @zdat, here's the new logic added since that version (introduced by #260):
This must be a side-effect of one these. Testing updates is so hard for me, so I rely on community support for this. Two potential ways to debug this:
The line setting The line setting |
Can confirm commenting out |
Thank you for the information @hafeoz. |
Just a heads-up, hope this will help: the deployment of Edge has been made more strict recently to the point where updates are being rolled back if the deployment fails. |
This commit fixes an issue where removing systems apps could disrupt Windows Cumulative updates as reported in #287. The fix involves removing the `EndOfLife` registry key after the app is removed. Keeping the key at `HKLM:\SOFTWARE\Microsoft\Windows\CurrentVersion\Appx\AppxAllUserStore\EndOfLife` was identified as the cause for update failures in #287. This commit also refactors the registry key creation/removal logic to be owned by separate functions for easier readability and reusability.
I see there is a commit that fixes this issue. What exactly should I do with this commit script to restore update functionality? I'm not sure what a commit is to be honest so I don't know if the script fixes the issue or it's something to be added later to the privacy.sexy next release or something. |
Hi, thank you for asking, I will released the fix version on Tuesday. However, it will not retroactively fix the issues but will not cause these issue in future. I will update here once the release is there, then you can run remove system apps again, until then, do not run system app removal scripts. For those who's seeing this thread later, the issue will be fixed since v0.12.8 so you shouldn't worry about, but if you deleted apps using older versions (v0.12.7 or v0.12.6), keep reading. Here's how you can fix the issue with updates (which seems to be caused by Microsoft refusing to do updates if it cannot install Edge):
|
The fix is released (the |
Remove bloatware > Remove Windows apps > Remove system apps... any one of these breaks Windows (commulative) updates.
This wasn't the case for 0.12.5(?) so I'm wondering which part each of these options has in common that breaks installing Windows commulative updates.
I can add that specific part to my "fix"/revert scripts. I'd rather not revert every single "Remove system apps" option every time I want to install a commulative update.
Can anyone help? Thanks.
The text was updated successfully, but these errors were encountered: