Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UNDERTOW-2385] Modify ThreadLocalCache using WeakHashMap #1589

Closed
wants to merge 2 commits into from
Closed

[UNDERTOW-2385] Modify ThreadLocalCache using WeakHashMap #1589

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d578811
[UNDERTOW-2385] Modify ThreadLocalCache using WeakHashMap
May 3, 2024
f1f959e
[UNDERTOW-2385] Avoid star import
May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/src/main/java/io/undertow/server/DefaultByteBufferPool.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@
import java.nio.ByteBuffer;
import java.util.ArrayDeque;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error: /home/runner/work/undertow/undertow/core/src/main/java/io/undertow/server/DefaultByteBufferPool.java:27: Using the '.' form of import should be avoided - java.util.. [AvoidStarImport]

import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.WeakHashMap;
import java.util.concurrent.ConcurrentLinkedQueue;
import java.util.concurrent.atomic.AtomicIntegerFieldUpdater;

Expand Down Expand Up @@ -343,7 +343,7 @@ protected void finalize() throws Throwable {
// class can be called by a different thread than the one that initialized the data.
private static class ThreadLocalCache {

Map<Thread, ThreadLocalData> localsByThread = new HashMap<>();
Map<Thread, ThreadLocalData> localsByThread = new WeakHashMap<>();

ThreadLocalData get() {
return localsByThread.get(Thread.currentThread());
Expand Down