Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix empty flags when Trivy persistence is disabled #278

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

matheusfm
Copy link
Contributor

Description

This PR fixes how the flag of Trivy persistence is passed to Operator when it is disabled.
A double quote was being passed instead of a empty string, causing the following error:

persistentvolumeclaim "\"\"" not found. preemption: 0/1 nodes are available: 1 No preemption victims found for incoming pod..

Linked Issues

UD-1385

How has this been tested?

  • Installing zora with trivy persistence disabled

Checklist

  • I have labeled this PR with the relevant Type labels
  • I have documented my code (if applicable)
  • My changes are covered by tests

@matheusfm matheusfm added the bug 🐛 Something isn't working label Apr 24, 2024
@matheusfm matheusfm requested review from knrc and lucasjct April 24, 2024 18:37
@matheusfm matheusfm self-assigned this Apr 24, 2024
Copy link
Contributor

@lucasjct lucasjct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matheusfm matheusfm merged commit 949d2f7 into main Apr 24, 2024
3 of 4 checks passed
@matheusfm matheusfm deleted the UD-1385-fix-empty-flags branch April 24, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants