Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to evaldown for examples and align plugin config with -dom. #43

Merged
merged 2 commits into from
Aug 16, 2020
Merged

Switch to evaldown for examples and align plugin config with -dom. #43

merged 2 commits into from
Aug 16, 2020

Conversation

alexjeffburke
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Aug 8, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-2.1%) to 94.681% when pulling d66937d on evaldown-and-align into 37475fb on master.

papandreou
papandreou approved these changes Aug 15, 2020
View reviewed changes
Copy link
Member

@papandreou papandreou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦖

Would be good to recover the lost coverage, but it looks low risk and nbd. Maybe we could try nyc evaldown... and combine the coverage reports, though?

@alexjeffburke
Copy link
Member Author

alexjeffburke commented Aug 16, 2020 •
edited
Loading

LGTM 🦖

Would be good to recover the lost coverage, but it looks low risk and nbd. Maybe we could try nyc evaldown... and combine the coverage reports, though?

Yeah, I guess I can try that - though I seem to remember that when this came up re core that the desire was plug the gaps in the actual test suite. Perhaps that is not just simpler but also better in the long run? If so, do you want that to block this PR?

@papandreou
Copy link
Member

No, when I approve a PR it means it's unblocked. I was just thinking out loud. It's obviously cleaner if the actual tests cover it, I was just curious if it would work.

@alexjeffburke
Copy link
Member Author

No, when I approve a PR it means it's unblocked. I was just thinking out loud. It's obviously cleaner if the actual tests cover it, I was just curious if it would work.

My apologies, I will take approval as writ going forward :)

@alexjeffburke alexjeffburke merged commit 6590597 into master Aug 16, 2020
@alexjeffburke alexjeffburke deleted the evaldown-and-align branch August 16, 2020 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@papandreou papandreou papandreou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexjeffburke @coveralls @papandreou