Inspect magicpen instances as a series of function calls #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…imply appending its value. I ran into troubles with testing error messages because the pen instances being tested were appended to the output despite being in a different format.
|
This could also be added to magicpen itself as a core style, or maybe be put into a |
|
Funny I had the exact same though, but discarded it because I thought it would be too hard to compare the output. But I guess this is the best we can do and it would definitely be helpful for simple cases. |
| if (isTopLevel && !pen.isEmpty() && (pen.format === this.format || !pen.format)) { | ||
| this.sp().commentBlock(pen); | ||
| } | ||
| }); | ||
| }; |
There was a problem hiding this comment.
I would prefer to split this into functions that would handle a line and a function that handle multiple lines. That would remove some of the nesting.
|
It is actually pretty helpful with the actual output on right side. |
|
Tried splitting it up. |
|
Thanks that is a bit more clean :-) |
sunesimonsen
added a commit
that referenced
this pull request
Aug 3, 2015
Inspect magicpen instances as a series of function calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.