Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prettier setup, run lebab, switch to 2 space indent #436

Merged
merged 32 commits into from
Feb 9, 2018

Conversation

papandreou
Copy link
Member

No description provided.

@sunesimonsen
Copy link
Member

Shouldn't you also lebabify the test folders?

@papandreou
Copy link
Member Author

Yeah, will do. I think it will take some time, though.

@sunesimonsen
Copy link
Member

@papandreou no pressure applied, I thought it was mostly automatic. We can just get there in multiple rounds.

@papandreou papandreou added the WIP label Feb 7, 2018
@papandreou
Copy link
Member Author

It's mostly that lebabing will change var to let/const in all the functions that are inspected in error messages that we're checking. We just have to work through it. For now I've added the WIP label :)

@sunesimonsen
Copy link
Member

Ahh I see.

@papandreou
Copy link
Member Author

Seems like I got this to work now. As I feared, it's not possible to apply lebab -t let and a few other transforms to the test folder, while keeping the tests running in Phantom.js and other environments where the transpiled unexpected.js is being tested. The problem is that functions that have been transpiled will have var in fn.toString(), but when testing with a recent node, it'll be let or const.

We'll need to get sunesimonsen/eslint-config-pretty-standard#6 in to be able to get npm install to work with node < 4. Seems like a good change anyway, then all the bundled plugins will be compatible with eslint 4, thus avoiding a peer dependency error.

@sunesimonsen
Copy link
Member

Woah it is green!

Copy link
Member

@sunesimonsen sunesimonsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 👍 thanks

@papandreou papandreou merged commit 05cd07b into master Feb 9, 2018
@papandreou papandreou deleted the feature/prettier branch February 9, 2018 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants