Skip to content
This repository has been archived by the owner on May 22, 2024. It is now read-only.

Feature/issue 592 add front and back to print view #192

Conversation

bspidel
Copy link
Collaborator

@bspidel bspidel commented Oct 17, 2017

This is hopelessly twisted with 766. Please have mercy

…o feature/Issue-766-disable_increment_of_last_updated_in_manifest_on_view_increment
…o feature/Issue-766-disable_increment_of_last_updated_in_manifest_on_view_increment
…o feature/Issue-766-disable_increment_of_last_updated_in_manifest_on_view_increment
Copy link
Member

@richmahn richmahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests are failing due to improper way to create a DateTime for last_updated in client_webhook.py. Make sure you run all unit tests locally to see any such problems.

@@ -88,6 +88,7 @@ def process_webhook(self):
'resource_type': rc.resource.type,
'title': rc.resource.title,
'manifest': json.dumps(rc.as_dict()),
'last_updated': datetime.utcnow
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're giving it a function reference here, rather than actually calling utcnow(). This is killing all the client_webhook tests.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 93.462% when pulling 7047c9c on bspidel:feature/Issue-592-add_front_and_back_to_print_view into bcfa472 on unfoldingWord-dev:develop.

Copy link
Member

@richmahn richmahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richmahn richmahn merged commit 982bcdd into unfoldingWord-dev:develop Oct 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants