Skip to content
This repository has been archived by the owner on May 22, 2024. It is now read-only.

Conversation

richmahn
Copy link
Member

Fixes Issue #495, unfoldingWord/door43.org#495 on the tx-manager side. Splits the request_job_handler.py into two handers: list_jobs and request_job. This makes it clearer what is going on when someone just wants to get information on a job. Before it request_job had to figure out if it was an existing job or a new job. Now they are separate and pointed to separately in the API Gateway.

@richmahn richmahn force-pushed the feature/495-split-request_job-into-two-functions branch 5 times, most recently from 3d67de8 to 3feea5b Compare March 17, 2017 18:58
@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 52.785% when pulling 3feea5b on richmahn:feature/495-split-request_job-into-two-functions into 68c4002 on unfoldingWord-dev:develop.

@richmahn richmahn force-pushed the feature/495-split-request_job-into-two-functions branch from 3feea5b to 6a318da Compare March 17, 2017 22:31
@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 52.785% when pulling 6a318da on richmahn:feature/495-split-request_job-into-two-functions into e2379d5 on unfoldingWord-dev:develop.

Copy link
Contributor

@phillip-hopper phillip-hopper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@phillip-hopper phillip-hopper merged commit 221f35b into unfoldingWord-dev:develop Mar 20, 2017
@richmahn richmahn deleted the feature/495-split-request_job-into-two-functions branch March 29, 2017 02:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants