-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle verse spans in the scripture viewer #329
Comments
@birchamp @elsylambert Currently in GWE we display the verse spans, but highlighting is not working. Phil 1:15-17 in en_ust is a good test example because it is both a span and is aligned: |
…hlightingForVerseRanges Feature #329/fix highlighting for verse ranges
@elsylambert This is in the latest RC: GWE v1.1.0 build 2747aff |
@PhotoNomad0 Please see the attached screenshot: in the latestGWE v1.1.0 build 2747aff QA server. For Phil 1:15-17, the highlights does not show for verse 15, but shows for 16 and 17. |
@elsylambert It works if you change occurrence to 1 |
Thanks @PhotoNomad0 it works. |
@elsylambert FYI - the alignment on the UST for that verse span |
Yeah @PhotoNomad0 I noticed that. Could it be data issue? I tried with occurrence 2 but it does not highlight with it. |
Hmm...both 1 & 2 are working for me when I use the same word you chose. |
Now it is highlighting a different word in UST @PhotoNomad0 |
@elsylambert do we need to meet after standup? I can bring up tCore to see how the ust is aligned, but It looks like it is highlighting properly. Maybe I need to google chiasm from the note and see if that means a mixed up order? |
@elsylambert maybe we should create an issue for GWE to highlight/flag invalid fields? - such as invalid occurrence number, missing supportReference, Notes, etc. ? @birchamp |
@PhotoNomad0 I made it #382 |
@elsylambert Think should help you match the highlighting in the UST alignment: |
Tested with v1.1.0 build 2747aff QA. Working properly |
Issue
—-
USFM that contains verse spans - \v 2-4 should display the text for that verse in gatewayEdit. The spanned text should be displayed for all verses in the span. ie. A verse span of \v 2-4 should show the text whether verse 2 or 3 or 4 is chosen in the reference navigator. The highlighting should work as if the text is a single verse.
DoD:
—-
Scripture that contains combined verses in a span should be displayed and highlighted in the scripture cards.
Details:
—-
Often translators have to combine the text of two or more verses in order to properly communicate the text correctly. The is represented in USFM by a verse marker followed by two numbers separated by a hyphen. (\v 2-4). The user expects a verse span to function just like all the other verses for all the checks for all the verses included in the span. An example of how this works is the scripture pane in translationCore.
The text was updated successfully, but these errors were encountered: