Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/11 #12

Merged
merged 7 commits into from
Jan 12, 2021
Merged

Fix/11 #12

merged 7 commits into from
Jan 12, 2021

Conversation

unfor19
Copy link
Owner

@unfor19 unfor19 commented Jan 12, 2021

Closes #11

The problem was in -

        expressions = \
            scrape_value_by_key(dashboard_body, "expr", str, []) \
            + scrape_value_by_key(dashboard_body, "query", str, [])

Previously, the function scrape_value_by_key used the default my_list=[], which caused a fixed reference to the same Python object list. Passing an empty list [] to this function sets the relevant expressions per dashboard.

@unfor19 unfor19 merged commit 74045c7 into master Jan 12, 2021
@unfor19 unfor19 deleted the fix/11 branch January 12, 2021 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metrics breakdown per dashboard
1 participant