Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add map apps #32

Merged
merged 3 commits into from
Feb 7, 2013
Merged

Add map apps #32

merged 3 commits into from
Feb 7, 2013

Conversation

nilclass
Copy link
Member

@nilclass nilclass commented Feb 7, 2013

Both dspace-client and smarkers work with the same data format (geoJSON FeatureCollections) now.

@jancborchardt
Copy link
Member

And there’s the »locations« module, even one of the first used by multiple
apps. @silverbucket was right after all. ;)

On Thu, Feb 7, 2013 at 3:03 PM, Niklas Cathor notifications@github.comwrote:

Both dspace-client http://dspace.nilclass.5apps.com/index.dev.html and
smarkers http://smarker.nilclass.5apps.com/ work with the same data

format (geoJSON FeatureCollections) now.

You can merge this Pull Request by running

git pull https://github.com/nilclass/unhosted-website add-map-apps

Or view, comment on, or merge it at:

#32
Commit Summary

  • added apps: dspace, smarkers
  • added uses-remotestorage to dspace and smarkers

File Changes

Patch Links:

@jancborchardt
Copy link
Member

@nilclass usability issue on smarkers: When I simply want to add a
location, filled out all the details and want to save, I am prompted to
»Add a collection first«. Then even when I add a collection and try to save
again I am prompted with that. I need to reload first. Also, what are
»collections« in the first place? I just want to add a location?

On Thu, Feb 7, 2013 at 4:04 PM, Jan-Christoph Borchardt <
hey@jancborchardt.net> wrote:

And there’s the »locations« module, even one of the first used by multiple
apps. @silverbucket was right after all. ;)

On Thu, Feb 7, 2013 at 3:03 PM, Niklas Cathor notifications@github.comwrote:

Both dspace-client http://dspace.nilclass.5apps.com/index.dev.html and
smarkers http://smarker.nilclass.5apps.com/ work with the same data

format (geoJSON FeatureCollections) now.

You can merge this Pull Request by running

git pull https://github.com/nilclass/unhosted-website add-map-apps

Or view, comment on, or merge it at:

#32
Commit Summary

  • added apps: dspace, smarkers
  • added uses-remotestorage to dspace and smarkers

File Changes

Patch Links:

@nilclass
Copy link
Member Author

nilclass commented Feb 7, 2013

@jancborchardt "collections" are GeoJSON Feature Collections. In smarkers, whenever you want to see or add markers (i.e. GeoJSON Features), you need to select a collection first. In dspace each collection will be displayed in it's own tab (though at the moment you will only see a collection named "test", because the UI for the tabs isn't done yet).

I agree that it's hardly a usable app, but a simple tool to populate your storage with location data. Realizing that, I am wondering if I should take that app out of this pull request again...

@jancborchardt
Copy link
Member

Yeah, it’s probably best to not add the app if it’s not intended or ready
to be properly used by people who are not us. This should go for all of the
apps on unhosted.org/apps

@michielbdejong I’m looking at you. ;) Maybe editor, social and email
should go below a header »for developers«. Then smarkers and other
unfinished or raw apps can be added there.

Sorry to veer off the topic here but whatever. What do you think?

On Thu, Feb 7, 2013 at 5:08 PM, Niklas Cathor notifications@github.comwrote:

@jancborchardt https://github.com/jancborchardt "collections" are GeoJSON
Feature Collectionshttp://www.geojson.org/geojson-spec.html#feature-collection-objects.
In smarkers, whenever you want to see or add markers (i.e. GeoJSON
Features), you need to select a collection first. In dspace each collection
will be displayed in it's own tab (though at the moment you will only see a
collection named "test", because the UI for the tabs isn't done yet).

I agree that it's hardly a usable app, but a simple tool to populate your
storage with location data. Realizing that, I am wondering if I should take
that app out of this pull request again...


Reply to this email directly or view it on GitHubhttps://github.com//pull/32#issuecomment-13242893.

@nilclass
Copy link
Member Author

nilclass commented Feb 7, 2013

@jancborchardt I think a separate section is better than removing the apps completely.

@jancborchardt
Copy link
Member

Yes, that’s what I was saying. A »In development« or similarly named header below the properly usable apps.

michielbdejong added a commit that referenced this pull request Feb 7, 2013
@michielbdejong michielbdejong merged commit 6c70546 into unhosted:master Feb 7, 2013
@michielbdejong
Copy link
Member

deployed! :) https://unhosted.org/apps/

@jancborchardt
Copy link
Member

Nice!

On Thu, Feb 7, 2013 at 6:11 PM, Michiel@unhosted
notifications@github.comwrote:

deployed! :) https://unhosted.org/apps/


Reply to this email directly or view it on GitHubhttps://github.com//pull/32#issuecomment-13246698.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants