Feature/neba 16 #27
Merged
Feature/neba 16 #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Renamed service interface to better reflect the fact that the mapping must be annotation-based.
- Added checkstyle rules and resolved checkstyle conformity issues
| * collection type, e.g. {@link java.util.List} or {@link java.util.Set}. Otherwise, an exception will arise. | ||
| * </p> | ||
| * | ||
| * <p> |
-Corrected synchronization and applied the same pattern to the model registry for consistency -Improved naming
| * @return the path of a field, as determined by the field name or {@link io.neba.api.annotations.Path path annotation}. Placeholders | ||
| * in the path are resolved at this point. Never <code>null</code>. | ||
| */ | ||
| String getFieldPath(); |
There was a problem hiding this comment.
Maybe getRepositoryPath() was better, I was thinking of a Java Field.
-Improved javadoc -Added the generic type parameter to the interface -improved method naming
|
In my project, we previously had two PostProcessors:
With this NEBA improvement I refactored the processors into field mappers:
So the functionality is basically the same, but the implementation is much easier now and less error-prone. LoC decreased by over 50%. Even though this complicates things in NEBA, I think it will be a great feature :) |
|
Allright! Wile this does increase complexity, I agree it could be an asset for complex projects and the architecture of the implementation is quite acceptable, as is the test coverage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the initial implementation of custom field mapper support in NEBA. Please review with a focus on the impact on architectural risk, performance and simplicity