Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neba-43 Added Page-Scroll-to-ID Plugin for Userguide Navigation #56

Merged
merged 1 commit into from
Mar 30, 2015
Merged

neba-43 Added Page-Scroll-to-ID Plugin for Userguide Navigation #56

merged 1 commit into from
Mar 30, 2015

Conversation

thedodobird2
Copy link
Contributor

  • Added the Page-Scroll-to-ID Plugin
  • Adjusted some files accordingly
  • Had to change the href"#..." and ID names
    • @, / and spaces caused the scrolling not to work (because in HTML4 they weren't allowed (we don't need them anyway))
    • deleted the @-symbols and replaced the slashes with underscores and the spaces with hyphens

Noted this where the function is called in main.js:

// IMPORTANT!
// Doesn't work if href="#..." includes any strange characters!
// ID's first character MUST be a letter not a number!
// ALLOWED CHARACTERS are: letters (a to z, A to Z), numbers (0-9), hyphens (-), underscores (_), colons (:) and periods (.).

olaf-otto added a commit that referenced this pull request Mar 30, 2015
neba-43 Added Page-Scroll-to-ID Plugin for Userguide Navigation
@olaf-otto olaf-otto merged commit 02edb9c into unic:gh-pages Mar 30, 2015
@olaf-otto
Copy link
Collaborator

Merged - thanks!

@thedodobird2 thedodobird2 deleted the feature/user-guide-scroll branch March 30, 2015 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants