leaderboard: issuers and earners list #51
Conversation
There was a problem hiding this comment.
A couple things.
Please comment on the issues you are working on. Please work on them sequentially and one at a time.
Before looking at #11, #10 requires changes. Please see my comments on the commits. The PR needs to fit the existing project.
#10 also requires
1. Mobile/Desktop views
Mobile needs updating:
4. Match the styles found at https://explorer.bounties.network/leaderboard and https://github.com/Bounties-Network/Explorer
There are also what appears to be system-wide packages included in your pr. None of this work requires additional packages to be installed and we aren't going to add lodash to the project in favor of modern js.
| @@ -0,0 +1,277 @@ | |||
| export const issuersData = [ | |||
There was a problem hiding this comment.
It would be really good to make a script of this.
Let's consider adding a script to populate the db with this data. We'll have to decide on a data model or consider what is already existing.
Thanks for this.
|
For whatever reason I cannot link you in tickets. |
|
@tenthirtyone Please review again and let me know the changes |
|
Hey, @tenthirtyone kindly review the changes. |
|
Mobile/Tablet Views changes: |
|
Hey, @tenthirtyone can you please review the changes. |
Fixes: #11
Fixes: #10
I have used the switch component from the link mentioned along with the CSS variables. Also, I have used dummy data present in the mock folder.
Let me know of the required changes @tenthirtyone @mehranhydary