Make blockquotes more pretty and make citation more clear #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwflory
reviewed
May 1, 2021
layouts/partials/head.html
Outdated
| @@ -17,7 +17,11 @@ | |||
| <link rel="icon" href="{{ `images/favicon.png` | absURL }}" type="image/x-icon"> | |||
|
|
|||
| {{ "<!-- fonts -->" | safeHTML }} | |||
| <link href="https://fonts.googleapis.com/css?family={{replace .Site.Params.font_family ' ' '+' | title}}:300,400,700&display=swap" rel="stylesheet"> | |||
| <link rel="preconnect" href="https://fonts.gstatic.com"> | |||
| <link href="https://fonts.googleapis.com/css2?family={{replace .Site.Params.font_family_a ' ' '+' | title}}+{{replace .Site.Params.font_family_b ' ' '+' | title}}:wght@300;400;700&display=swap" rel="stylesheet"> | |||
There was a problem hiding this comment.
Hmm, I am curious. Why was this change necessary? Not sure I follow your path of thinking.
There was a problem hiding this comment.
Remember
Hi @Idadelveloper, this looks great and I am almost ready to merge this! The only thing that is a red flag to me for this Pull Request is the way fonts are loaded into the theme from the config. It is possible there is a bug here you caught working on this, but if it is a bug, we should look at fixing this another way that does not depend on the config file values.
Does this make sense? Let me know if you have doubts. Thanks again for working on this! 🙌🏻
@jwflory there's definitely a bug. Will get rid of this change together with the changes in the config file.
jwflory
reviewed
May 1, 2021
layouts/partials/head.html
Outdated
| @@ -17,7 +17,11 @@ | |||
| <link rel="icon" href="{{ `images/favicon.png` | absURL }}" type="image/x-icon"> | |||
|
|
|||
| {{ "<!-- fonts -->" | safeHTML }} | |||
| <link href="https://fonts.googleapis.com/css?family={{replace .Site.Params.font_family ' ' '+' | title}}:300,400,700&display=swap" rel="stylesheet"> | |||
| <link rel="preconnect" href="https://fonts.gstatic.com"> | |||
There was a problem hiding this comment.
Is this a performance gain for loading font caches or something earlier? Sorry if it is an obvious question, I am curious. 🙊
There was a problem hiding this comment.
@jwflory really has nothing much to do with performance. So when "Open+Sans" is used it is not being parsed correctly therefore an error shows in the console.
I just removed the changes I made in this file and the config file. We could figure out a better way to tackle this :)
There was a problem hiding this comment.
@Idadelveloper Good catch here. I didn't notice this bug until now. You could open an issue on unicef/inventory so we could talk through how best to fix that one.
jwflory
reviewed
May 1, 2021
jwflory
requested changes
May 1, 2021
There was a problem hiding this comment.
Hi @Idadelveloper, this looks great and I am almost ready to merge this! The only thing that is a red flag to me for this Pull Request is the way fonts are loaded into the theme from the config. It is possible there is a bug here you caught working on this, but if it is a bug, we should look at fixing this another way that does not depend on the config file values.
Does this make sense? Let me know if you have doubts. Thanks again for working on this! 🙌🏻
This commit tackles the issue in the inventory repo on making blockquotes more pretty and citation clear (unicef/inventory#14) Signed-off-by: Ida Delphine <idadelm@gmail.com>
jwflory
approved these changes
May 2, 2021
jwflory
added a commit
to unicef/inventory
that referenced
this pull request
May 2, 2021
This incorporates work from PR unicef/inventory-hugo-theme#2 by @Idadelveloper. It pulls commits to make the blockquotes more visually appealing. And it supports images, nice! This likely needs corresponding documentation, but will revisit this farther down the line. Contributes to #14 but does not close it. PR #23 will require rebasing for a passing CI build. Signed-off-by: Justin W. Flory (he/him) [UNICEF Innovation] <jflory@unicef.org>
jwflory
pushed a commit
that referenced
this pull request
Aug 10, 2021
This commit tackles the issue in the inventory repo on making blockquotes more pretty and citation clear (unicef/inventory#14) Signed-off-by: Ida Delphine <idadelm@gmail.com>
jwflory
pushed a commit
that referenced
this pull request
Aug 13, 2021
* assets: Enhance look of blockquotes and citation (#2) This commit tackles the issue in the inventory repo on making blockquotes more pretty and citation clear (unicef/inventory#14) Signed-off-by: Ida Delphine <idadelm@gmail.com> * layouts: Add big quotes to citation Signed-off-by: Ida Delphine <mida@unicef.org>
jwflory
pushed a commit
that referenced
this pull request
Aug 13, 2021
Pull Requests #2 and #8. Corresponds to unicef/inventory#14. This commit tackles the issue in the inventory repo on making blockquotes more pretty and citation clear. Signed-off-by: Ida Delphine <idadelm@gmail.com> Show big quotes for citation (#8) * assets: Enhance look of blockquotes and citation (#2) This commit tackles the issue in the inventory repo on making blockquotes more pretty and citation clear (unicef/inventory#14) Signed-off-by: Ida Delphine <idadelm@gmail.com> * layouts: Add big quotes to citation Signed-off-by: Ida Delphine <mida@unicef.org>
jwflory
pushed a commit
that referenced
this pull request
Sep 10, 2021
Pull Requests #2 and #8. Corresponds to unicef/inventory#14. This commit tackles the issue in the inventory repo on making blockquotes more pretty and citation clear. Signed-off-by: Ida Delphine <idadelm@gmail.com> Show big quotes for citation (#8) * assets: Enhance look of blockquotes and citation (#2) This commit tackles the issue in the inventory repo on making blockquotes more pretty and citation clear (unicef/inventory#14) Signed-off-by: Ida Delphine <idadelm@gmail.com> * layouts: Add big quotes to citation Signed-off-by: Ida Delphine <mida@unicef.org>
jwflory
pushed a commit
that referenced
this pull request
Sep 15, 2021
Pull Requests #2 and #8. Corresponds to unicef/inventory#14. This commit tackles the issue in the inventory repo on making blockquotes more pretty and citation clear. Signed-off-by: Ida Delphine <idadelm@gmail.com> Show big quotes for citation (#8) * assets: Enhance look of blockquotes and citation (#2) This commit tackles the issue in the inventory repo on making blockquotes more pretty and citation clear (unicef/inventory#14) Signed-off-by: Ida Delphine <idadelm@gmail.com> * layouts: Add big quotes to citation Signed-off-by: Ida Delphine <mida@unicef.org>
jwflory
pushed a commit
that referenced
this pull request
Oct 10, 2021
Pull Requests #2 and #8. Corresponds to unicef/inventory#14. This commit tackles the issue in the inventory repo on making blockquotes more pretty and citation clear. Signed-off-by: Ida Delphine <idadelm@gmail.com> Show big quotes for citation (#8) * assets: Enhance look of blockquotes and citation (#2) This commit tackles the issue in the inventory repo on making blockquotes more pretty and citation clear (unicef/inventory#14) Signed-off-by: Ida Delphine <idadelm@gmail.com> * layouts: Add big quotes to citation Signed-off-by: Ida Delphine <mida@unicef.org>
jwflory
pushed a commit
that referenced
this pull request
Oct 13, 2021
Pull Requests #2 and #8. Corresponds to unicef/inventory#14. This commit tackles the issue in the inventory repo on making blockquotes more pretty and citation clear. Signed-off-by: Ida Delphine <idadelm@gmail.com> Show big quotes for citation (#8) * assets: Enhance look of blockquotes and citation (#2) This commit tackles the issue in the inventory repo on making blockquotes more pretty and citation clear (unicef/inventory#14) Signed-off-by: Ida Delphine <idadelm@gmail.com> * layouts: Add big quotes to citation Signed-off-by: Ida Delphine <mida@unicef.org>
jwflory
pushed a commit
that referenced
this pull request
Oct 14, 2021
Pull Requests #2 and #8. Corresponds to unicef/inventory#14. This commit tackles the issue in the inventory repo on making blockquotes more pretty and citation clear. Signed-off-by: Ida Delphine <idadelm@gmail.com> Show big quotes for citation (#8) * assets: Enhance look of blockquotes and citation (#2) This commit tackles the issue in the inventory repo on making blockquotes more pretty and citation clear (unicef/inventory#14) Signed-off-by: Ida Delphine <idadelm@gmail.com> * layouts: Add big quotes to citation Signed-off-by: Ida Delphine <mida@unicef.org>
jwflory
pushed a commit
that referenced
this pull request
Nov 19, 2021
Pull Requests #2 and #8. Corresponds to unicef/inventory#14. This commit tackles the issue in the inventory repo on making blockquotes more pretty and citation clear. Signed-off-by: Ida Delphine <idadelm@gmail.com> Show big quotes for citation (#8) * assets: Enhance look of blockquotes and citation (#2) This commit tackles the issue in the inventory repo on making blockquotes more pretty and citation clear (unicef/inventory#14) Signed-off-by: Ida Delphine <idadelm@gmail.com> * layouts: Add big quotes to citation Signed-off-by: Ida Delphine <mida@unicef.org>
jwflory
pushed a commit
that referenced
this pull request
Nov 23, 2021
Pull Requests #2 and #8. Corresponds to unicef/inventory#14. This commit tackles the issue in the inventory repo on making blockquotes more pretty and citation clear. Signed-off-by: Ida Delphine <idadelm@gmail.com> Show big quotes for citation (#8) * assets: Enhance look of blockquotes and citation (#2) This commit tackles the issue in the inventory repo on making blockquotes more pretty and citation clear (unicef/inventory#14) Signed-off-by: Ida Delphine <idadelm@gmail.com> * layouts: Add big quotes to citation Signed-off-by: Ida Delphine <mida@unicef.org>
jwflory
pushed a commit
that referenced
this pull request
Dec 22, 2021
Pull Requests #2 and #8. Corresponds to unicef/inventory#14. This commit tackles the issue in the inventory repo on making blockquotes more pretty and citation clear. Signed-off-by: Ida Delphine <idadelm@gmail.com> Show big quotes for citation (#8) * assets: Enhance look of blockquotes and citation (#2) This commit tackles the issue in the inventory repo on making blockquotes more pretty and citation clear (unicef/inventory#14) Signed-off-by: Ida Delphine <idadelm@gmail.com> * layouts: Add big quotes to citation Signed-off-by: Ida Delphine <mida@unicef.org>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jwflory this PR handles the styling for issue #14 in the inventory repo.
PS: My vs code formatter kinda made changes throughout the css file. The changes I really made are from line 594.