-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
assets: Ensure colors conform to UNICEF branding #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ida Delphine <mida@unicef.org>
jwflory
approved these changes
Oct 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pulled this change down and reviewed locally along with unicef/inventory#74. Looks good to me! And I actually think the color choices have a nicer contrast too. 😅
Merging! 🎬
jwflory
added a commit
to Idadelveloper/inventory
that referenced
this pull request
Oct 7, 2021
This pulls down latest changes on color scheme introduced by @Idadelveloper in unicef/inventory-hugo-theme#21. The color scheme used across the Inventory will now comply with the UNICEF brand book. Closes unicef/inventory-hugo-theme#19. Signed-off-by: Justin W. Flory (he/him) [UNICEF Innovation] <jflory@unicef.org>
jwflory
added a commit
to Idadelveloper/inventory
that referenced
this pull request
Oct 7, 2021
This pulls down latest changes on color scheme introduced by @Idadelveloper in unicef/inventory-hugo-theme#21. The color scheme used across the Inventory will now comply with the UNICEF brand book. Closes unicef/inventory-hugo-theme#19. Signed-off-by: Justin W. Flory (he/him) [UNICEF Innovation] <jflory@unicef.org>
jwflory
added a commit
to unicef/inventory
that referenced
this pull request
Oct 7, 2021
* config: Ensure colors conform to UNICEF's branding Signed-off-by: Ida Delphine <mida@unicef.org> * 📦 ⬇️ theme: Sync submodule with upstream This pulls down latest changes on color scheme introduced by @Idadelveloper in unicef/inventory-hugo-theme#21. The color scheme used across the Inventory will now comply with the UNICEF brand book. Closes unicef/inventory-hugo-theme#19. Signed-off-by: Justin W. Flory (he/him) [UNICEF Innovation] <jflory@unicef.org> Co-authored-by: Justin W. Flory (he/him) [UNICEF Innovation] <jflory@unicef.org>
jwflory
added
the
hacktoberfest-accepted
This change was accepted as part of the annual Hacktoberfest event organized by DigitalOcean
label
Oct 7, 2021
jwflory
pushed a commit
that referenced
this pull request
Oct 10, 2021
This commit groups changes related to UNICEF's brand and design requirements for the Inventory theme. It also includes color contrast changes to improve accessibility for people with visual impairments. Related Pull Requests: * #6 * #21 * #22 * unicef/inventory#76 Related Issues: * unicef/inventory#13 * unicef/inventory#32 * #17 * #19 Signed-off-by: Ida Delphine <mida@unicef.org> Co-authored-by: Ida Delphine <mida@unicef.org>
jwflory
pushed a commit
that referenced
this pull request
Oct 13, 2021
This commit groups changes related to UNICEF's brand and design requirements for the Inventory theme. It also includes color contrast changes to improve accessibility for people with visual impairments. Related Pull Requests: * #6 * #21 * #22 * unicef/inventory#76 Related Issues: * unicef/inventory#13 * unicef/inventory#32 * #17 * #19 Signed-off-by: Ida Delphine <mida@unicef.org> Co-authored-by: Ida Delphine <mida@unicef.org>
jwflory
pushed a commit
that referenced
this pull request
Oct 14, 2021
This commit groups changes related to UNICEF's brand and design requirements for the Inventory theme. It also includes color contrast changes to improve accessibility for people with visual impairments. Related Pull Requests: * #6 * #21 * #22 * unicef/inventory#76 Related Issues: * unicef/inventory#13 * unicef/inventory#32 * #17 * #19 Signed-off-by: Ida Delphine <mida@unicef.org> Co-authored-by: Ida Delphine <mida@unicef.org>
jwflory
pushed a commit
that referenced
this pull request
Nov 19, 2021
This commit groups changes related to UNICEF's brand and design requirements for the Inventory theme. It also includes color contrast changes to improve accessibility for people with visual impairments. Related Pull Requests: * #6 * #21 * #22 * unicef/inventory#76 Related Issues: * unicef/inventory#13 * unicef/inventory#32 * #17 * #19 Signed-off-by: Ida Delphine <mida@unicef.org> Co-authored-by: Ida Delphine <mida@unicef.org>
jwflory
pushed a commit
that referenced
this pull request
Nov 23, 2021
This commit groups changes related to UNICEF's brand and design requirements for the Inventory theme. It also includes color contrast changes to improve accessibility for people with visual impairments. Related Pull Requests: * #6 * #21 * #22 * unicef/inventory#76 Related Issues: * unicef/inventory#13 * unicef/inventory#32 * #17 * #19 Signed-off-by: Ida Delphine <mida@unicef.org> Co-authored-by: Ida Delphine <mida@unicef.org>
jwflory
pushed a commit
that referenced
this pull request
Dec 22, 2021
This commit groups changes related to UNICEF's brand and design requirements for the Inventory theme. It also includes color contrast changes to improve accessibility for people with visual impairments. Related Pull Requests: * #6 * #21 * #22 * unicef/inventory#76 Related Issues: * unicef/inventory#13 * unicef/inventory#32 * #17 * #19 Signed-off-by: Ida Delphine <mida@unicef.org> Co-authored-by: Ida Delphine <mida@unicef.org>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
hacktoberfest-accepted
This change was accepted as part of the annual Hacktoberfest event organized by DigitalOcean
T: improvement
Improves on something that already exists
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ida Delphine mida@unicef.org
This tackles #19