PR for #12 Highlight related articles at the bottom of each article. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MuluhGodson
changed the title
|
@jwflory I think I already opened a PR |
jwflory
approved these changes
May 8, 2021
There was a problem hiding this comment.
Hi @MuluhGodson, this change looks good to me. Apologies for the delay on reviewing this; I got the title mixed up with unicef/inventory#25.
One quick note for the record. This is part of the implementation I wanted, but does not implement the keyword matching for related articles in the same category with tags. It only shows other random articles from the same category. That's OK, but this will not close unicef/inventory#12.
jwflory
pushed a commit
that referenced
this pull request
May 8, 2021
✂️ Trim hanging whitespace characters Signed-off-by: Justin W. Flory (he/him) [UNICEF Innovation] <jflory@unicef.org>
jwflory
added a commit
to unicef/inventory
that referenced
this pull request
May 8, 2021
This commit updates the git submodule with @MuluhGodson's changes added in unicef/inventory-hugo-theme#4. Articles can now support front matter for their categories, and articles sharing the same category may appear as related articles at the bottom of the page. Part of #12, but does not yet close it. Signed-off-by: Justin W. Flory (he/him) [UNICEF Innovation] <jflory@unicef.org>
jwflory
pushed a commit
that referenced
this pull request
Aug 10, 2021
✂️ Trim hanging whitespace characters Signed-off-by: Justin W. Flory (he/him) [UNICEF Innovation] <jflory@unicef.org>
jwflory
pushed a commit
that referenced
this pull request
Aug 13, 2021
✂️ Trim hanging whitespace characters Signed-off-by: Justin W. Flory (he/him) [UNICEF Innovation] <jflory@unicef.org>
jwflory
pushed a commit
that referenced
this pull request
Sep 10, 2021
✂️ Trim hanging whitespace characters Signed-off-by: Justin W. Flory (he/him) [UNICEF Innovation] <jflory@unicef.org>
jwflory
pushed a commit
that referenced
this pull request
Sep 15, 2021
✂️ Trim hanging whitespace characters Signed-off-by: Justin W. Flory (he/him) [UNICEF Innovation] <jflory@unicef.org>
jwflory
pushed a commit
that referenced
this pull request
Oct 10, 2021
✂️ Trim hanging whitespace characters Signed-off-by: Justin W. Flory (he/him) [UNICEF Innovation] <jflory@unicef.org>
jwflory
pushed a commit
that referenced
this pull request
Oct 13, 2021
✂️ Trim hanging whitespace characters Signed-off-by: Justin W. Flory (he/him) [UNICEF Innovation] <jflory@unicef.org>
jwflory
pushed a commit
that referenced
this pull request
Oct 14, 2021
✂️ Trim hanging whitespace characters Signed-off-by: Justin W. Flory (he/him) [UNICEF Innovation] <jflory@unicef.org>
jwflory
pushed a commit
that referenced
this pull request
Nov 19, 2021
✂️ Trim hanging whitespace characters Signed-off-by: Justin W. Flory (he/him) [UNICEF Innovation] <jflory@unicef.org>
jwflory
pushed a commit
that referenced
this pull request
Nov 23, 2021
✂️ Trim hanging whitespace characters Signed-off-by: Justin W. Flory (he/him) [UNICEF Innovation] <jflory@unicef.org>
jwflory
pushed a commit
that referenced
this pull request
Dec 22, 2021
✂️ Trim hanging whitespace characters Signed-off-by: Justin W. Flory (he/him) [UNICEF Innovation] <jflory@unicef.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a section to display related articles.