Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve user experience of Cohorts sidebar navigation #110

Merged
merged 2 commits into from
Feb 3, 2022
Merged

Improve user experience of Cohorts sidebar navigation #110

merged 2 commits into from
Feb 3, 2022

Conversation

Idadelveloper
Copy link
Contributor

@jwflory this addresses #27

It looks like this:
improved-sidebar

@jwflory jwflory self-assigned this Dec 23, 2021
@jwflory jwflory added the T: improvement Improves on something that already exists label Dec 23, 2021
@jwflory jwflory force-pushed the fix/sidebar branch 3 times, most recently from d5325ca to 20e392a Compare December 23, 2021 22:15
jwflory
jwflory requested changes Dec 23, 2021
View reviewed changes
Copy link
Member

@jwflory jwflory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following up from stand-up, we will land the sidebar partial into the theme repository to ease future integration of the team profiles feature into the theme.

I tried to replicate the results in the screenshot, but I was unable to. I had different results when I cloned down the repo:

Screenshot of Cohorts page on a 1080p monitor

Screenshot of Blockchain Cohort page on a 1080p monitor

Screenshot of Cohorts page on a 640p viewport

Are there corresponding changes inside the theme that should go with this PR? I would guess something is different in the stylesheets between us.

@Idadelveloper
Copy link
Contributor Author

Idadelveloper commented Dec 27, 2021 •
edited
Loading

@jwflory the reason your results are different is that I made some changes as well in the CSS file of the theme. Will send a PR.
Just a little confused why the dropdown icon isn't displaying. At the moment we can't see the scrollbar because there are not enough startup teams per cohort.

@Idadelveloper
Copy link
Contributor Author

@jwflory I moved the sidebar partial to the theme unicef/inventory-hugo-theme#45

@jwflory
Copy link
Member

jwflory commented Jan 5, 2022

Blocking this on unicef/inventory-hugo-theme#45.

@jwflory jwflory added the ?: blocked Progress blocked by another task or issue label Jan 5, 2022
jwflory added a commit to unicef/inventory-hugo-theme that referenced this pull request Jan 10, 2022
@Idadelveloper @jwflory
Improve UI/UX for sidebar (#45)
7043edc 
Closes #27. Related to unicef/inventory#110.

* Add styles for scrollbar of sidebar
* Add sidebar partial
* Adjust sidebar for non-cohort pages

Signed-off-by: Ida Delphine <mida@unicef.org>

* Update assets/css/style.css

Co-authored-by: Justin W. Flory (he/him) [UNICEF Innovation] <jflory@unicef.org>
Co-authored-by: Justin W. Flory <jflory7@gmail.com>
@jwflory
Copy link
Member

jwflory commented Jan 10, 2022

@Idadelveloper What do we want to do with this Pull Request since unicef/inventory-hugo-theme#45 was merged?

@jwflory jwflory assigned Idadelveloper and unassigned jwflory Jan 10, 2022
@jwflory
Copy link
Member

jwflory commented Jan 10, 2022

Rebased on commit 4bfd52c.

@jwflory jwflory mentioned this pull request Jan 10, 2022
Closed
5 tasks
@jwflory jwflory changed the title Improve user experience of sidebar navigation Improve user experience of Cohorts sidebar navigation Jan 12, 2022
@Idadelveloper
Copy link
Contributor Author

@jwflory this PR is supposed to address the weird sidebar of the cohort pages

@jwflory
Copy link
Member

jwflory commented Jan 18, 2022

Some quick feedback, but the sidebars do not seem to share all of the same code. The dropdowns do not have a scrollbar and there seems to be extra whitespace at the end of the sub-menu. I don't see that issue with another section on the site, like the Meta category.

Cohorts sidebar menu.

Category sidebar menu. This is the Meta category.

@Idadelveloper Any idea why this is? I can't debug at the moment.

@jwflory jwflory removed the ?: blocked Progress blocked by another task or issue label Jan 18, 2022
@jwflory
Copy link
Member

jwflory commented Jan 19, 2022 via email •
edited
Loading

@Idadelveloper @jwflory
Add sidebar partial
278e79f 
Signed-off-by: Ida Delphine <mida@unicef.org>
jwflory pushed a commit to unicef/inventory-hugo-theme that referenced this pull request Jan 25, 2022
@Idadelveloper
💄 css: Adjust sidebar scroll spacing (#51)
4228680 
Related to unicef/inventory#110.
@jwflory
Update git submodule with unicef/inventory-hugo-theme#51
fe731a9 
Signed-off-by: Justin W. Flory (he/him) [UNICEF Innovation] <jflory@unicef.org>
@jwflory
Copy link
Member

jwflory commented Jan 25, 2022

The cohorts page now has the fixed sidebar, but the sidebar disappears completely on individual profile pages. Not sure what the root cause is, but I will try to dig in and investigate why this is.

@jwflory jwflory added the ?: blocked Progress blocked by another task or issue label Jan 25, 2022
@jwflory jwflory self-assigned this Jan 25, 2022
@jwflory jwflory removed the ?: blocked Progress blocked by another task or issue label Feb 3, 2022
@jwflory jwflory merged commit 70949a9 into unicef:main Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwflory jwflory jwflory approved these changes

Assignees

@jwflory jwflory

@Idadelveloper Idadelveloper

Labels
T: improvement Improves on something that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Idadelveloper @jwflory