-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restructure around dpg standards #136
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just taking a quick pass here! Looking good so far, but I'll test it locally once the layout is pushed up in a new Pull Request for the theme. Some quick comments and notes below to help guide you as you are working through this.
content/open source resources and best practices/mentorship/_index.en.adoc
Outdated
Show resolved
Hide resolved
@Neha9849 Could you please update this Pull Request with commits from the staging site? As a note, I think we should sync the There could also be a stretch project of improving our Continuous Integration pipeline so previews are built automatically without taking the extra steps we are taking here. Something to tuck away for after the restructure. 😀 |
In today's sprint retrospective, let's see if we can get Edit: Done! |
This fix is useful for DPG indicators restructure (unicef/inventory#136 and #144). If there is no content in a particular DPG indicator then this change will show the description of that page there.
Repasting from a review in unicef/inventory-hugo-theme#144:
|
Rebased on latest |
Rebased on latest |
Rebased on latest |
Note to self, this pull request needs to have a hard reset on |
This commit represents the sum changes for migrating the UNICEF Open Source Inventory to a new support structure modeled around the Digital Public Good Standard. Based on user testing research, the interface is made to be more useful for a project or Venture Fund start-up company aiming to achieve compliance with the Digital Public Good Standard. Redirects with page aliases are in place so all URL addresses from the old organizational model will redirect to the correct place. Closes unicef/inventory-hugo-theme#126. === :memo: Change DPG Indicators page type to dpg-standard This adopts the expected layout for the DPG Indicators, with a mini profile for each indicator. Signed-off-by: Justin W. Flory (he/him) [UNICEF Innovation] <jflory@unicef.org>
This changes the user experience to make the user more aware that by visiting another UNICEF Toolkit, they will go to a different website. This addresses feedback from user research testing that found the "Toolkits" navbar option to be confusing, since the website and content changed but the general UI/UX remains the same. This change makes the redirect more obvious. It leverages the page redirect used previously in the Data Transparency & Ethics category in the Open Source Inventory. Closes unicef/inventory-hugo-theme#156.
Rebased on latest |
This commit shows the "team" template type on the index page of the site. The use case for this change is so that the total cohorts view still appears when navigating to `/inventory/cohorts/` and it also appears as its own category on the site homepage alongside other topics. This contributes to unblocking unicef/inventory#136. Signed-off-by: Justin W. Flory (he/him) [UNICEF Innovation] <jflory@unicef.org>
This commit shows the "team" template type on the index page of the site. The use case for this change is so that the total cohorts view still appears when navigating to `/inventory/cohorts/` and it also appears as its own category on the site homepage alongside other topics. This contributes to unblocking unicef/inventory#136. Signed-off-by: Justin W. Flory (he/him) [UNICEF Innovation] <jflory@unicef.org> Signed-off-by: Justin W. Flory (he/him) [UNICEF Innovation] <jflory@unicef.org>
Pulls the needed change from unicef/inventory-hugo-theme#174 and returns the original layout used for the all cohorts template view. Signed-off-by: Justin W. Flory (he/him) [UNICEF Innovation] <jflory@unicef.org>
The need for the staging site will go away once this commit is merged to `main` branch of `unicef/inventory`. Signed-off-by: Justin W. Flory (he/him) [UNICEF Innovation] <jflory@unicef.org>
A page redirect doesn't work on index pages. Instead, this page should be populated with basic information and the reader is encouraged to visit the SDG goals website for more information. Signed-off-by: Justin W. Flory (he/him) [UNICEF Innovation] <jflory@unicef.org>
This commit includes several minor to moderate changes that prepares the DPG Standard indicator redesign to deploy to production: 1. Add `keywords` to post front-matter in order to better utilize the search bar function. 2. Remove `categories` front-matter from posts since this metadata is implicitly inherited by path. 3. Add and/or modify `tags` in many posts. 4. Fix aliases missing a starting `/` so they work as expected (previously, many aliases were incomplete and not working). 5. Minor formatting and syntax: Remove unnecessary quotemarks, change order of some front-matter, use alphabetical sorts, etc. 6. Reorganize some articles from one DPG Indicator to another. This happened mostly among DPG Indicators 2, 3, and 8. 7. Use Themify icon set for home page categories. Only set an `icon` front-matter for content categories that appear on the site index page. 8. Propose pages for deletion, using a `warning` admonition to give ample notice that a page may disappear from the site. 9. Utilize new site features in older content, like the page author and table of contents. Signed-off-by: Justin W. Flory (he/him) [UNICEF Innovation] <jflory@unicef.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional work was needed to finalize this change. Changes made in commit 547525c:
- Add
keywords
to post front-matter in order to better utilize the search bar function. - Remove
categories
front-matter from posts since this metadata is implicitly inherited by path. - Add and/or modify
tags
in many posts. - Fix aliases missing a starting
/
so they work as expected (previously, many aliases were incomplete and not working) - Minor formatting and syntax: Remove unnecessary quotemarks, change order of some front-matter, use alphabetical sorts, etc.
- Reorganize some articles from one DPG Indicator to another. This happened mostly among DPG Indicators 2, 3, and 8.
- Use Themify icon set for home page categories. Only set an
icon
front-matter for content categories that appear on the site index page. - Propose pages for deletion, using a
warning
admonition to give ample notice that a page may disappear from the site. - Utilize new site features in older content, like the page author and table of contents.
I believe this is now ready. Since this PR is a very large change, I want to make one final pass before approving. I'll review this one more time over the next week, and if only minor or no changes, I will approve and merge. |
Some minor changes and improvements from the final review: * Change an AsciiDoc `:author:` tag to article `author:` front-matter * Remove wrapped quotation marks from more metadata fields * Add more tags and keywords to some articles * Add more aliases to previous paths for historical preservation (they were accidentally deleted during the reorganization) Signed-off-by: Justin W. Flory (he/him) [UNICEF Innovation] <jflory@unicef.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some final changes in commit 5e97993. This is now ready for merging! Pushing to production shortly. 🚀
No description provided.