Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to pod annotations through values file #30

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

ckittelmann
Copy link
Contributor

I added the possibility to set pod annotations for drill and zookeeper. Its optional and no braking change

@merlos merlos added helm Issue that requires the change of a helm chart good first contribution labels Aug 27, 2024
@merlos
Copy link
Member

merlos commented Aug 27, 2024

Hey @ckittelmann
Thanks for the submission.
Would you mind to add in the values.yaml file a comment that documents the existence of this option and an example of usage?

Will merge after that.
Thanks!

@ckittelmann
Copy link
Contributor Author

Thx for your feedback @merlos :) I added the examples

I already opened another PR for pod priorities and will add another one for configurable affinity ...just in case you are planing a new release

@merlos merlos changed the title pod annotations can now be set Support to pod annotations through values file Aug 28, 2024
@merlos merlos merged commit 5c24457 into unicef:main Aug 28, 2024
@ckittelmann ckittelmann deleted the pod-annotations branch August 28, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first contribution helm Issue that requires the change of a helm chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants