Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow icu_testdata's BakedDataProvider to be broken down by component and experiment #2383

Closed
1 task
sffc opened this issue Aug 16, 2022 · 2 comments
Closed
1 task
Assignees
Labels
C-data-infra Component: provider, datagen, fallback, adapters

Comments

@sffc
Copy link
Member

sffc commented Aug 16, 2022

Currently icu_testdata's BakedDataProvider is monolithic and pulls in all ICU4X components, including experimental ones. The feature is generally disabled because of the compile times. Both of these issues could be resolved if we made each part of BakedDataProvider be feature-gated. For example, "icu_datetime" could dev-depend on "icu_testdata/icu_datetime" (and whichever other components it needs, like "icu_testdata/icu_decimal").

We also want for the icu_datetime/experimental feature to be optional.

@sffc sffc added the needs-approval One or more stakeholders need to approve proposal label Aug 16, 2022
@robertbastian robertbastian self-assigned this Aug 16, 2022
@sffc
Copy link
Member Author

sffc commented Aug 19, 2022

For crates with experimental features, here is what I propose

  1. Add a testdata feature called e.g. icu_datetime_experimental (optionally remove the "icu_" prefix if you do so for the other features)
  2. Tests in icu_datetime that need data hidden behind icu_testdata/icu_datetime_experimental should use the serde data instead, until Allow optional dev-dependencies rust-lang/cargo#1596 is fixed.

@robertbastian
Copy link
Member

Fixed by #2364

@sffc sffc added this to the ICU4X 1.0 (Final) milestone Sep 8, 2022
@sffc sffc closed this as completed Sep 8, 2022
@sffc sffc added C-data-infra Component: provider, datagen, fallback, adapters and removed needs-approval One or more stakeholders need to approve proposal labels Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-data-infra Component: provider, datagen, fallback, adapters
Projects
None yet
Development

No branches or pull requests

2 participants