Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support key and locale filtering in datagen #830

Closed
sffc opened this issue Jun 28, 2021 · 1 comment
Closed

Support key and locale filtering in datagen #830

sffc opened this issue Jun 28, 2021 · 1 comment
Labels
blocked A dependency must be resolved before this is actionable C-data-infra Component: provider, datagen, fallback, adapters R-obsolete Resolution: This issue is no longer relevant S-epic Size: Major project (create smaller child issues) T-core Type: Required functionality

Comments

@sffc
Copy link
Member

sffc commented Jun 28, 2021

Currently we only support the --all-keys and --all-locales options in icu4x-datagen, except for the special flags for test data. We need to implement the filtering by keys and locales.

For filtering by keys, we should first support static code analysis to detect which keys are in use. For filtering by locales, we should wait for a resolution on #173.

Related and possible duplicate: #192

@sffc sffc added T-core Type: Required functionality C-data-infra Component: provider, datagen, fallback, adapters blocked A dependency must be resolved before this is actionable S-epic Size: Major project (create smaller child issues) R-obsolete Resolution: This issue is no longer relevant labels Jun 28, 2021
@sffc
Copy link
Member Author

sffc commented Jun 29, 2021

Obsolete: we already do the locale filtering, and key filtering is tracked by #192.

@sffc sffc closed this as completed Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked A dependency must be resolved before this is actionable C-data-infra Component: provider, datagen, fallback, adapters R-obsolete Resolution: This issue is no longer relevant S-epic Size: Major project (create smaller child issues) T-core Type: Required functionality
Projects
None yet
Development

No branches or pull requests

1 participant