Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Laravel-Emojis] Add more facial emojis (emoticons) #2

Merged
merged 3 commits into from
Jun 6, 2016
Merged

[Laravel-Emojis] Add more facial emojis (emoticons) #2

merged 3 commits into from
Jun 6, 2016

Conversation

vdugeri
Copy link

@vdugeri vdugeri commented Apr 11, 2016

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 62.5% when pulling e6f473c on andela-vdugeri:feature/face-emojis into 2723f85 on unicodeveloper:master.

"stuck_out_tongue_closed_eyes" => "\u{1F61D}",
"disappointed" => "\u{1F61E}",
"angry" => "\u{1F620}",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can you ensure they are ordered appropriately via the unicode value? You actually ordered a greater part of it but I think "relaxed" should be the last, "relieved" should come just after "yum" .

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the late reply, jus seeing this now. Will work on it ASAP

@unicodeveloper
Copy link
Owner

Please, what's the latest on this @andela-vdugeri ?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 62.5% when pulling fd99026 on andela-vdugeri:feature/face-emojis into 2723f85 on unicodeveloper:master.

@unicodeveloper
Copy link
Owner

Please rebase @andela-vdugeri

@unicodeveloper
Copy link
Owner

@andela-vdugeri Just a subtle reminder. Please can you rebase, so that I can merge this in 😊

@coveralls
Copy link

Coverage Status

Coverage remained the same at 62.5% when pulling 7ee1839 on andela-vdugeri:feature/face-emojis into a9a3df1 on unicodeveloper:master.

@unicodeveloper
Copy link
Owner

Great @andela-vdugeri

@unicodeveloper unicodeveloper merged commit d79dcae into unicodeveloper:master Jun 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants