[USD-162] cmap parse patch #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampila
commented
Jan 21, 2022
gunnsth
reviewed
Jan 30, 2022
There was a problem hiding this comment.
Can you add a short PR comment about what changes this includes.
It seems like those changes are kind of a patch for a few cases that we have run into rather than an improvement of the implementation. That is OK, we will probably want to refactor this in the future or build into unitype.
Added a few comments
go.mod
Outdated
| @@ -0,0 +1,8 @@ | |||
| module github.com/unidoc/freetype | |||
|
|
|||
| go 1.17 | |||
There was a problem hiding this comment.
can drop this down to 1.14 or something?
truetype/truetype.go
Outdated
| } | ||
|
|
||
| if gid > 0 { | ||
| //b := runeDecoder.ToBytes(uint32(c)) |
gunnsth
reviewed
Jan 30, 2022
go.mod
Outdated
| go 1.14 | ||
|
|
||
| require ( | ||
| github.com/golang/freetype v0.0.0-20170609003504-e2365dfdc4a0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[USD-162] Simple font with subtable format(1,0) Macintosh Simple Encoding and cmap format0 parse implementation.
[USD-168] Simple font with subtabel format(3,0) Microsoft Symbol Encoding and cmap format4 patch, use unitype implementation if the freetype can't parse the cmap index correctly.