Cache remapping weights #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 4, 2021 10:17
This way, the expensive computation of the weights is done once in set up, and then the weights are hold on to through the `RegridOperator` to be used when transfers are retrieved and remapping is required.
Following the evolving API of `cf-python` on this newly created functionality, we agreed that the method was unnecessary where using a `RegridOperator`.
rich-HJ
approved these changes
Jun 10, 2021
That's the hope. 😁 They pass locally. I don't see a reason why they would fail, but we shall see that when v3.10.0 is released. Thank for the review Rich. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #43
Following a PR in
cf-pythonNCAS-CMS/cf-python#223, theregrids/regridcmethods of acf.Fieldcan now return aRegridOperatorso that the remapping weights are calculated then, and stored in the RegridOperator which can be re-used on demand later on.This PR makes use of this new feature is the
set_upof theExchanger, where theRegridOperatoris computed once if remapping is required, and then used inget_transfer.This PR requires
cf-python>=3.10.0to work, so I expect our tests to fail because this version has not been released on PyPI yet. While their PR is merged in their master branch already, I would rather not modify our GitHub Actions workflow to install from their repo rather than from PyPI.