Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readme: Add Hint about duplicate symbols #21

Closed
wants to merge 1 commit into from
Closed

Readme: Add Hint about duplicate symbols #21

wants to merge 1 commit into from

Conversation

mkroening
Copy link
Member

Reopened #3. Migrated from skuenzer#1.

CC: @razvand

@mkroening mkroening mentioned this pull request Jul 7, 2023
Closed
razvand
razvand requested changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use a single line for a sentence. Whenever there is a dot (.) add a newline. Also, don't break a sentence into multiple lines. One sentence, one and only one line.

The rationale behind this is doing easy documentation reviews.

@mkroening mkroening requested a review from razvand July 7, 2023 15:47
razvand
razvand approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@razvand razvand left a comment •
edited by nderjung
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mkroening. A welcomed addition. @skuenzer , please approve it if it's OK with you.

Reviewed-by: Razvan Deaconescu razvand@unikraft.io

skuenzer
skuenzer approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@skuenzer skuenzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @mkroening, really useful to document.

Approved-by: Simon Kuenzer simon@unikraft.io

@razvand razvand added documentation Improvements or additions to documentation enhancement New feature or request labels Jul 11, 2023
@mkroening mkroening deleted the dup-symbols branch July 11, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@razvand razvand razvand approved these changes

@skuenzer skuenzer skuenzer approved these changes

Assignees

@skuenzer skuenzer

Labels
ci/merged documentation Improvements or additions to documentation enhancement New feature or request
Projects
Unikraft Core Roadmap
Status: ✅ Done!
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mkroening @razvand @skuenzer @unikraft-bot