This repository has been archived by the owner on Mar 2, 2024. It is now read-only.
Add run scripts and documentation #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
razvand
suggested changes
Jul 1, 2023
There was a problem hiding this comment.
@John-Ted, see my comments. Also update your commit message. See the similar commit for app-nginx. Squash the commits.
Add a commit to ignore output files and directories. See the similar commit for app-nginx.
Remove trailing white spaces.
John-Ted
force-pushed
the
add-scripts
branch
3 times, most recently
from
72bfc30
to
26b2ed6
Compare
John-Ted
changed the title
StefanJum
suggested changes
Jul 1, 2023
StefanJum
suggested changes
Jul 1, 2023
There was a problem hiding this comment.
@John-Ted please wrap the commit description lines from this commit to ~72 characters. Everything seems fine besides that.
razvand
approved these changes
Jul 1, 2023
Update the README with instructions on setting up, configuring, building and running the Redis app with Unikraft. As part of it, add Makefile files, configuration files and scripts; they are referenced in the `README.md` file. Current instructions cover the use of QEMU/KVM platform (both on x86_64 and on AArch64) and GCC. Firecraker/KVM, Xen, Linux platforms and Clang are not yet documented. Signed-off-by: Ioan-Teodor Teugea <ioan_teodor.teugea@stud.acs.upb.ro>
Ignore files and folder that are output from the set up, configure, build or run steps. Signed-off-by: Ioan-Teodor Teugea <ioan_teodor.teugea@stud.acs.upb.ro>
This is done in order to align with the new build naming conventions. Signed-off-by: Ioan-Teodor Teugea <ioan_teodor.teugea@stud.acs.upb.ro>
StefanJum
approved these changes
Jul 1, 2023
unikraft-bot
pushed a commit
that referenced
this pull request
Jul 1, 2023
Ignore files and folder that are output from the set up, configure, build or run steps. Signed-off-by: Ioan-Teodor Teugea <ioan_teodor.teugea@stud.acs.upb.ro> Reviewed-by: Razvan Deaconescu <razvand@unikraft.io> Approved-by: Stefan Jumarea <stefanjumarea02@gmail.com> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: #16
unikraft-bot
pushed a commit
that referenced
this pull request
Jul 1, 2023
This is done in order to align with the new build naming conventions. Signed-off-by: Ioan-Teodor Teugea <ioan_teodor.teugea@stud.acs.upb.ro> Reviewed-by: Razvan Deaconescu <razvand@unikraft.io> Approved-by: Stefan Jumarea <stefanjumarea02@gmail.com> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: #16
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.