Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(library): Introduce Java 17 as library #52

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

razvand
Copy link
Contributor

@razvand razvand commented Jan 28, 2024

Introduce Java 17 image (ELF Loader) for bincompat runs.

Add Kraftfile to build for QMEU and Firecracker on x86_64 using initrd for volume support. The current build uses embedded initrd to build a single image consisting of both the kernel and the initial ramdisk.

Add GitHub workflow to build and deploy the image. Add success badge in README.md.

@razvand razvand added the enhancement New feature or request label Jan 28, 2024
@razvand razvand added this to the v0.17.0 (Calypso) milestone Jan 28, 2024
@razvand razvand requested a review from csvancea January 28, 2024 11:26
library/java/17/Kraftfile Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@razvand razvand force-pushed the razvand/library/java branch 2 times, most recently from 38475c8 to a0a7334 Compare February 7, 2024 15:17
@Mihnea0Firoiu
Copy link
Member

It fails to build rootfs:

<!> building rootfs                                                            x86_64 [0.0s]
 W  could not connect to BuildKit client, is BuildKit running?
 W  
 W  By default, KraftKit will look for a native install which
 W  is located at /run/buildkit/buildkit.sock.  Alternatively, you
 W  can run BuildKit in a container (recommended for macOS users)
 W  which you can do by running:
 W  
 W    docker run --rm -d --name buildkit --privileged moby/buildkit:latest
 W    export KRAFTKIT_BUILDKIT_HOST=docker-container://buildkit
 W  
 W  For more usage instructions visit: https://unikraft.org/buildkit
 W  
 E  could not get BuildKit info: failed to call info: Unavailable: connection error: desc = 
 E  could not get BuildKit info: failed to call info: Unavailable: connection error: desc = 

Am I doing something wrong? For another app from library, such as nginx, it works.

@Mihnea0Firoiu
Copy link
Member

It fails to build rootfs:

<!> building rootfs                                                            x86_64 [0.0s]
 W  could not connect to BuildKit client, is BuildKit running?
 W  
 W  By default, KraftKit will look for a native install which
 W  is located at /run/buildkit/buildkit.sock.  Alternatively, you
 W  can run BuildKit in a container (recommended for macOS users)
 W  which you can do by running:
 W  
 W    docker run --rm -d --name buildkit --privileged moby/buildkit:latest
 W    export KRAFTKIT_BUILDKIT_HOST=docker-container://buildkit
 W  
 W  For more usage instructions visit: https://unikraft.org/buildkit
 W  
 E  could not get BuildKit info: failed to call info: Unavailable: connection error: desc = 
 E  could not get BuildKit info: failed to call info: Unavailable: connection error: desc = 

Am I doing something wrong? For another app from library, such as nginx, it works.

Fixed the issue, I just had to run BuildKit into a container, as is written above.

Copy link
Member

@StefanJum StefanJum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good.
Reviewed-by: Stefan Jumarea stefanjumarea02@gmail.com

Copy link
Member

@Mihnea0Firoiu Mihnea0Firoiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!
Reviewed-by: Mihnea Firoiu mihneafiroiu0@gmail.com

@razvand razvand linked an issue Mar 4, 2024 that may be closed by this pull request
Copy link
Member

@StefanJum StefanJum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can merge this, running the application fails with the issue described in #67

Reviewed-by: Stefan Jumarea stefanjumarea02@gmail.com
Approved-by: Stefan Jumarea stefanjumarea02@gmail.com

library/java/17/README.md Outdated Show resolved Hide resolved
@razvand razvand requested a review from nderjung August 22, 2024 11:29
@razvand razvand assigned StefanJum and unassigned nderjung Aug 22, 2024
@razvand razvand removed the request for review from nderjung August 22, 2024 11:29
@razvand razvand removed this from the v0.17.0 (Calypso) milestone Aug 22, 2024
Introduce Java 17 image (ELF Loader) for bincompat runs.

Add `Kraftfile` to build for QMEU and Firecracker on x86_64 using initrd
for volume support. The current build uses embedded initrd to build a
single image consisting of both the kernel and the initial ramdisk.

Add GitHub workflow to build and deploy the image. Add success badge in
`README.md`.

Signed-off-by: Razvan Deaconescu <razvand@unikraft.io>
Copy link
Member

@StefanJum StefanJum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Stefan Jumarea stefanjumarea02@gmail.com
Approved-by: Stefan Jumarea stefanjumarea02@gmail.com

@StefanJum StefanJum merged commit 581aff1 into unikraft:main Aug 22, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

java:17: Crash when started
4 participants