Makefile.uk: Fix subdirectory make rule #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since commit unikraft/b8872a6 of the Unikraft core was merged, `mk_sub_build_dir` will only create a top-level new directory, so using it to create `libuuid/include/public` and `libuuid/include/private` is not possible. Use `mk_sub_libbuild_dir` instead, which can create a full path to a directory. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com>
mariasfiraiala
approved these changes
Aug 10, 2023
There was a problem hiding this comment.
Thanks for the fix @StefanJum!
Reviewed-by: Maria Sfiraiala maria.sfiraiala@gmail.com
RaduNichita
approved these changes
Aug 10, 2023
There was a problem hiding this comment.
Also works on my side, reviewed this as I had some problems with running app-python with the staging branch.
Reviewed-by: Radu Nichita radunichita99@gmail.com
razvand
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since commit unikraft/b8872a6 of the Unikraft core was merged,
mk_sub_build_dirwill only create a top-level new directory, so usingit to create
libuuid/include/publicandlibuuid/include/privateisnot possible.
Use
mk_sub_libbuild_dirinstead, which can create a full path to a directory.Signed-off-by: Stefan Jumarea stefanjumarea02@gmail.com