Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RAW socket type to LwIP #2

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

flapjack321
Copy link
Contributor

Added RAW config option into lwipopts.h.
Updated Config.uk to reflect option addition.

Signed-off-by: Ethan Cotterell e.cotterell@lancaster.ac.uk

@skuenzer skuenzer requested review from skuenzer and removed request for hisharanwithu October 19, 2021 09:31
@nderjung nderjung force-pushed the flapjack321/add-raw branch 3 times, most recently from 8223890 to 933c0af Compare November 12, 2021 15:44
Config.uk Show resolved Hide resolved
@razvand razvand added the enhancement New feature or request label Nov 27, 2021
@razvand
Copy link
Contributor

razvand commented Mar 26, 2022

@flapjack321 , @nderjung , what was the reasoning for adding SOCK_RAW socket type?

@nderjung nderjung force-pushed the flapjack321/add-raw branch 3 times, most recently from 4a68271 to a2166d6 Compare May 26, 2022 08:27
@razvand razvand requested review from nderjung and skuenzer May 26, 2022 08:37
@razvand razvand assigned skuenzer and unassigned nderjung May 26, 2022
@razvanvirtan razvanvirtan added this to the v0.11.0 (Janus) milestone Oct 6, 2022
@skuenzer
Copy link
Member

@flapjack321 , @nderjung , what was the reasoning for adding SOCK_RAW socket type?

Applications that use the raw socket API can send custom packets. I think some networking tools like traceroute or ping use this.

@nderjung nderjung removed this from the v0.11.0 (Janus) milestone Feb 12, 2023
@nderjung nderjung changed the base branch from staging to pr-2 November 24, 2023 14:07
This commit optionalizes LwIP's "RAW" protocol, making it available to
use within Unikraft when enabled.

Signed-off-by: Ethan Cotterell <e.cotterell@lancs.ac.uk>
Signed-off-by: Alexander Jung <a.jung@lancs.ac.uk>
Copy link
Member

@skuenzer skuenzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the updates!

Reviewed-by: Simon Kuenzer simon@unikraft.io
Approved-by: Simon Kuenzer simon@unikraft.io

Config.uk Outdated Show resolved Hide resolved
@skuenzer skuenzer changed the base branch from pr-2 to staging-2 November 24, 2023 15:42
@skuenzer skuenzer merged commit 18caf82 into unikraft:staging-2 Nov 24, 2023
skuenzer pushed a commit that referenced this pull request Nov 24, 2023
This commit optionalizes LwIP's "RAW" protocol, making it available to
use within Unikraft when enabled.

Signed-off-by: Ethan Cotterell <e.cotterell@lancs.ac.uk>
Signed-off-by: Alexander Jung <a.jung@lancs.ac.uk>
Reviewed-by: Simon Kuenzer <simon@unikraft.io>
Approved-by: Simon Kuenzer <simon@unikraft.io>
GitHub-Closes: #2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done!
Status: Done
Status: review:invalid
Development

Successfully merging this pull request may close these issues.

5 participants