Prepare lwip to provde DNS functions to native musl #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Kuenzer <simon@unikraft.io>
For better ABI compatibility and interopability, the data types that are defined in `<lwip/netdb.h>` are replaced by the ones shipped with the musl library (`<netdb.h>`) if available. Signed-off-by: Simon Kuenzer <simon@unikraft.io>
skuenzer
changed the title
eduardvintila
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
Thanks!
Reviewed-by: Eduard Vintilă eduard.vintila47@gmail.com
andreistan26
approved these changes
Feb 7, 2024
There was a problem hiding this comment.
Looks good to me, thanks!
Reviewed-by: Andrei Stan andreistan2003@gmail.com
razvand
approved these changes
Feb 9, 2024
There was a problem hiding this comment.
Reviewed-by: Razvan Deaconescu razvand@unikraft.io
Approved-by: Razvan Deaconescu razvand@unikraft.io
razvand
pushed a commit
that referenced
this pull request
Feb 9, 2024
Signed-off-by: Simon Kuenzer <simon@unikraft.io> Reviewed-by: Eduard Vintilă <eduard.vintila47@gmail.com> Reviewed-by: Razvan Deaconescu <razvand@unikraft.io> Approved-by: Razvan Deaconescu <razvand@unikraft.io> GitHub-Closes: #48
razvand
pushed a commit
that referenced
this pull request
Feb 9, 2024
For better ABI compatibility and interopability, the data types that are defined in `<lwip/netdb.h>` are replaced by the ones shipped with the musl library (`<netdb.h>`) if available. Signed-off-by: Simon Kuenzer <simon@unikraft.io> Reviewed-by: Eduard Vintilă <eduard.vintila47@gmail.com> Reviewed-by: Razvan Deaconescu <razvand@unikraft.io> Approved-by: Razvan Deaconescu <razvand@unikraft.io> GitHub-Closes: #48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prepares lwip so that musl can directly use lwip's DNS functionality to implement DNS hostname resolution.