Expose LWIP_SO_RCVBUF config and set on by default #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change exposes the LWIP_SO_RCVBUF config option through the Unikraft Kconfig, configuring whether lwip should use receive buffers. Receive buffers enable support for the SO_RCVBUF socket option as well as ioctl(FIONREAD). This option is enabled by default to provide the most compatibility. Signed-off-by: Andrei Tatar <andrei@unikraft.io>
eduardvintila
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
Good addition, thx.
Reviewed-by: Eduard Vintilă eduard.vintila47@gmail.com
andreistan26
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
Looks good, thanks!
Reviewed-by: Andrei Stan andreistan2003@gmail.com
razvand
approved these changes
Feb 7, 2024
razvand
pushed a commit
that referenced
this pull request
Feb 7, 2024
This change exposes the LWIP_SO_RCVBUF config option through the Unikraft Kconfig, configuring whether lwip should use receive buffers. Receive buffers enable support for the SO_RCVBUF socket option as well as ioctl(FIONREAD). This option is enabled by default to provide the most compatibility. Signed-off-by: Andrei Tatar <andrei@unikraft.io> Reviewed-by: Eduard Vintilă <eduard.vintila47@gmail.com> Approved-by: Razvan Deaconescu <razvand@unikraft.io> GitHub-Closes: #50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This change exposes the LWIP_SO_RCVBUF config option through the Unikraft Kconfig, configuring whether lwip should use receive buffers. Receive buffers enable support for the SO_RCVBUF socket option as well as ioctl(FIONREAD).
This option is enabled by default to provide the most compatibility.
Testing
On
staging,setsockopt(SO_RCVBUF)orioctl(FIONREAD)on a LWIP socket will error out withENOSYS.After this patch, these functions are available depending on the
CONFIG_LWIP_RCVBUFKconfig option.