-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
glue: Init libc.auxv to point to a zero value #53
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, I added one comment.
The `libc.auxv` is not supposed to be 0, since it will be dereferenced by any call to `getauxval`. It should point to a 0 value instead. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com>
5f1ede3
to
b1f0d94
Compare
Done @mschlumpp, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed-by: Marco Schlumpp marco@unikraft.io
@StefanJum, should we then close PR |
Yes, closed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved-by: Razvan Deaconescu razvand@unikraft.io
The
libc.auxv
is not supposed to be 0, since it will be dereferenced by any call togetauxval
.It should point to a 0 value instead.