Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glue: Init libc.auxv to point to a zero value #53

Closed

Conversation

StefanJum
Copy link
Member

The libc.auxv is not supposed to be 0, since it will be dereferenced by any call to getauxval.
It should point to a 0 value instead.

Copy link
Member

@mschlumpp mschlumpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, I added one comment.

__uk_init_tls.c Show resolved Hide resolved
The `libc.auxv` is not supposed to be 0, since it will be dereferenced
by any call to `getauxval`. It should point to a 0 value instead.

Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com>
@StefanJum
Copy link
Member Author

Done @mschlumpp, thanks.

@razvand razvand requested a review from mschlumpp May 31, 2023 20:40
@razvand razvand self-assigned this May 31, 2023
@razvand razvand added the enhancement New feature or request label May 31, 2023
@razvand razvand added this to the v0.14.0 (Prometheus) milestone May 31, 2023
Copy link
Member

@mschlumpp mschlumpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Marco Schlumpp marco@unikraft.io

@razvand
Copy link
Contributor

razvand commented Jun 1, 2023

@StefanJum, should we then close PR 913 in the Unikraft core repository?

@StefanJum
Copy link
Member Author

@StefanJum, should we then close PR 913 in the Unikraft core repository?

Yes, closed.

Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved-by: Razvan Deaconescu razvand@unikraft.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/merged enhancement New feature or request
Projects
Status: Done!
Development

Successfully merging this pull request may close these issues.

4 participants