Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include missing parts of the string library #55

Closed
wants to merge 1 commit into from

Conversation

andreittr
Copy link
Contributor

The string part of libc was previously missing <memory.h> and explicit_bzero.c, which this change fixes.

@razvand razvand self-assigned this Jun 28, 2023
@razvand razvand added the enhancement New feature or request label Jun 28, 2023
@razvand razvand added this to the v0.14.0 (Prometheus) milestone Jun 28, 2023
Copy link
Member

@StefanJum StefanJum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thanks.

Reviewed-by: Stefan Jumarea stefanjumarea02@gmail.com

Copy link
Member

@eduardvintila eduardvintila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

Reviewed-by: Eduard Vintilă eduard.vintila47@gmail.com

Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved-by: Razvan Deaconescu razvand@unikraft.io

The string part of libc was previously missing <memory.h> and
explicit_bzero.c, which this change fixes.

Signed-off-by: Andrei Tatar <andrei@unikraft.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/merged enhancement New feature or request
Projects
Status: Done!
Development

Successfully merging this pull request may close these issues.

5 participants