Redis 7.0.11 #10

John-Ted · 2023-06-05T13:19:08Z

Update redis to 7.0.11

This library was built using musl, some patches are not compatible with pthread-embedded.

Based on #4

StefanJum

Thank you @John-Ted.

Some other things besides the comments:

Update the commit messages and add short descriptions when needed (e.g. explain what new source files were added, explain what patcher were added, explain why histogram was added as a dependency).
Sign-off the commits with the same email you added in the Makefile.uk authors.
Check that everything that is moved from LIBREDIS_SERVER to LIBREDIS_COMMON makes sense to be moved there. LIBREDIS_COMMON should be a list of everything that is needed both by the server and the client, and it should be minimal.

patches/0001-deps-hiredis-Remove-unused-dependency-to-tcp.patch

patches/0004-src-Change-header-path-to-relative.patch

patches/0006-src-Change-name-of-server-main-to-avoid-clash.patch

patches/0007-src-Ensure-compatibility-with-pthread-embedded.patch

patches/0010-remove-unnecessary-header.patch

Makefile.uk

RaduNichita

At least on my side, there seem to be a problem with timestamps.

For aarch64, the timestamp appear to be -748823 Jan 1970 -19:-36:00.145, whereas for qemux86_64 it appears to be 28 Jul 2015 07:49:05.074

@John-Ted do you have any idea why this may be happening?

Otherwise, I have been able to test and the things seems fine. 💯

patches/0010-remove-unnecessary-header.patch

John-Ted · 2023-07-30T10:19:42Z

In regards to the timestamps, on ARM the gettimeofday call does not function properly. On x86, I tracked it down to this 1, which calls their version of localtime with the server.timezone parameter, which is subtracted from the timestamp 2. This variable has the value 263675520, which corresponds to a shift of about 8 years, consistent with the change from 2023 to 2015.

StefanJum

Works great @John-Ted, thank you.
Please start your commit messages with a capital letter.
Also see the changes to the commits below:

bump version to 7.0.11 -> Bump version from ---- to 7.0.11
Add a description of what changes needed to be made, new dependencies, new patches, etc.
refactor code into single library -> Makefile.uk: Refactor code into single library
Also add a description here, state that previously there were separate libraries for
LIBREDIS_SERVER, LIBREDIS_CLIENT, LIBREDIS_COMMON, now we do the separation
by config options.
improve patches -> patches: Impove patches
Also, I would only leave this to remove the unnecessary patches, and update patch 6 in
the commit that adds it.
So in the end the commit would be patches: Remove unnecesarry patches.

StefanJum

@John-Ted should this commit be part of this one? We should try to keep it as bisect-friendly as possible, ideally if you check out on any of the commits the library should compile fine.

RaduNichita

For the commit 1b46aa5 ( patches: Remove unnecessary patches) , please state why these patches are not necessarry anymore.

StefanJum

Looks fine to me besides the one comment @John-Ted, I'll wait for @RaduNichita to also test on his side.

StefanJum · 2023-07-30T13:07:21Z

Makefile.uk

-LIBREDIS_COMMON_SRCS-y += $(LIBREDIS_SRC)/release.c
-LIBREDIS_COMMON_SRCS-y += $(LIBREDIS_SRC)/siphash.c
-LIBREDIS_COMMON_SRCS-y += $(LIBREDIS_SRC)/zmalloc.c
+LIBREDIS_SRCS-y += $(LIBREDIS_SRC)/adlist.c


Please order the LIBREDIS_SRCS source files in lexicographic order.

StefanJum

All good on my side, thank you. I'll add the tag after @RaduNichita is happy.

RaduNichita

All good with me now. I am happy!

Reviewed-by: Radu Nichita radunichita99@gmail.com

StefanJum

Approved-by: Stefan Jumarea stefanjumarea02@gmail.com

Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@gmail.com>

Histogram is a new dependency introduced by Redis Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@gmail.com>

Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@gmail.com>

Add new source files introduced by Redis Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@gmail.com>

Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@gmail.com>

Because we use musl, several patches that changed pthreads calls to work with newlib are no longer needed and have been removed. Removed a patch that would remove an `#include` directive from the code as that header is now necessary. Removed a patch that would add a relative import path to a header, as that path is part of `CINCLUDES`. Added a patch that removes a header which causes compilation errors. Signed-off-by: Ioan-Teodor Teugea <ioan_teodor.teugea@stud.acs.upb.ro>

Previously, the code was compiled into 3 different libraries, LIBREDIS_SERVER, LIBREDIS_CLIENT and LIBREDIS_COMMON. This commit changes this so the code is compiled into a single library, LIBREDIS, which enables the server or the client functionality based on the config options. Signed-off-by: Ioan-Teodor Teugea <ioan_teodor.teugea@stud.acs.upb.ro>

Histogram is a new dependency introduced by Redis Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@gmail.com> Reviewed-by: Radu Nichita <radunichita99@gmail.com> Approved-by: Stefan Jumarea <stefanjumarea02@gmail.com> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: #10

Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@gmail.com> Reviewed-by: Radu Nichita <radunichita99@gmail.com> Approved-by: Stefan Jumarea <stefanjumarea02@gmail.com> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: #10

Add new source files introduced by Redis Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@gmail.com> Reviewed-by: Radu Nichita <radunichita99@gmail.com> Approved-by: Stefan Jumarea <stefanjumarea02@gmail.com> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: #10

Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@gmail.com> Reviewed-by: Radu Nichita <radunichita99@gmail.com> Approved-by: Stefan Jumarea <stefanjumarea02@gmail.com> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: #10

Because we use musl, several patches that changed pthreads calls to work with newlib are no longer needed and have been removed. Removed a patch that would remove an `#include` directive from the code as that header is now necessary. Removed a patch that would add a relative import path to a header, as that path is part of `CINCLUDES`. Added a patch that removes a header which causes compilation errors. Signed-off-by: Ioan-Teodor Teugea <ioan_teodor.teugea@stud.acs.upb.ro> Reviewed-by: Radu Nichita <radunichita99@gmail.com> Approved-by: Stefan Jumarea <stefanjumarea02@gmail.com> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: #10

Previously, the code was compiled into 3 different libraries, LIBREDIS_SERVER, LIBREDIS_CLIENT and LIBREDIS_COMMON. This commit changes this so the code is compiled into a single library, LIBREDIS, which enables the server or the client functionality based on the config options. Signed-off-by: Ioan-Teodor Teugea <ioan_teodor.teugea@stud.acs.upb.ro> Reviewed-by: Radu Nichita <radunichita99@gmail.com> Approved-by: Stefan Jumarea <stefanjumarea02@gmail.com> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: #10

John-Ted force-pushed the redis-7.0.11 branch from 830f398 to d85fb70 Compare July 1, 2023 06:37

razvand assigned StefanJum Jul 16, 2023

razvand requested a review from RaduNichita July 16, 2023 11:49

razvand added the enhancement New feature or request label Jul 16, 2023

StefanJum suggested changes Jul 18, 2023

View reviewed changes

RaduNichita reviewed Jul 21, 2023

View reviewed changes

patches/0010-remove-unnecessary-header.patch Outdated Show resolved Hide resolved

John-Ted mentioned this pull request Jul 25, 2023

redis-benchmark gives Too many open files in system when running with -c 100 unikraft/unikraft#1003

Open

John-Ted force-pushed the redis-7.0.11 branch from d85fb70 to b204755 Compare July 30, 2023 09:24

John-Ted requested review from RaduNichita and StefanJum July 30, 2023 10:19

StefanJum suggested changes Jul 30, 2023

View reviewed changes

John-Ted force-pushed the redis-7.0.11 branch from b204755 to 4e4c620 Compare July 30, 2023 10:53

John-Ted requested a review from StefanJum July 30, 2023 10:53

StefanJum suggested changes Jul 30, 2023

View reviewed changes

RaduNichita suggested changes Jul 30, 2023

View reviewed changes

John-Ted force-pushed the redis-7.0.11 branch from 4e4c620 to 8682c5f Compare July 30, 2023 12:52

John-Ted requested review from StefanJum and RaduNichita July 30, 2023 12:53

StefanJum reviewed Jul 30, 2023

View reviewed changes

John-Ted force-pushed the redis-7.0.11 branch from 8682c5f to fca5cb4 Compare July 30, 2023 13:27

John-Ted requested a review from StefanJum July 30, 2023 13:28

StefanJum approved these changes Jul 30, 2023

View reviewed changes

RaduNichita approved these changes Jul 30, 2023

View reviewed changes

StefanJum approved these changes Jul 30, 2023

View reviewed changes

craciunoiuc added 5 commits August 2, 2023 20:46

Makefile: Bump version and change source

d6b0bd8

Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@gmail.com>

Config: Add Histogram as dependency

88768c1

Histogram is a new dependency introduced by Redis Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@gmail.com>

Makefile: Add Histogram sources

7127af5

Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@gmail.com>

Makefile: Add new Redis sources

e874d47

Add new source files introduced by Redis Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@gmail.com>

patches: Update list of patches to fix incompatibilities

83ba97a

Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@gmail.com>

John-Ted added 2 commits August 2, 2023 20:46

John-Ted force-pushed the redis-7.0.11 branch from fca5cb4 to 02948a2 Compare August 2, 2023 17:47

unikraft-bot closed this in d0e2f50 Aug 4, 2023

unikraft-bot added the ci/merged label Aug 4, 2023

StefanJum mentioned this pull request Aug 7, 2023

Bump version of Redis: 5.0.6 -> 7.0.5 #4

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Redis 7.0.11 #10

Redis 7.0.11 #10

John-Ted commented Jun 5, 2023 •

edited

Loading

StefanJum left a comment

RaduNichita left a comment

John-Ted commented Jul 30, 2023

StefanJum left a comment

StefanJum left a comment

RaduNichita left a comment

StefanJum left a comment

StefanJum Jul 30, 2023

StefanJum left a comment

RaduNichita left a comment •

edited

Loading

StefanJum left a comment

Redis 7.0.11 #10

Redis 7.0.11 #10

Conversation

John-Ted commented Jun 5, 2023 • edited Loading

StefanJum left a comment

Choose a reason for hiding this comment

RaduNichita left a comment

Choose a reason for hiding this comment

John-Ted commented Jul 30, 2023

StefanJum left a comment

Choose a reason for hiding this comment

StefanJum left a comment

Choose a reason for hiding this comment

RaduNichita left a comment

Choose a reason for hiding this comment

StefanJum left a comment

Choose a reason for hiding this comment

StefanJum Jul 30, 2023

Choose a reason for hiding this comment

StefanJum left a comment

Choose a reason for hiding this comment

RaduNichita left a comment • edited Loading

Choose a reason for hiding this comment

StefanJum left a comment

Choose a reason for hiding this comment

John-Ted commented Jun 5, 2023 •

edited

Loading

RaduNichita left a comment •

edited

Loading