lib/vfscore: Fix getcwd to use the kernel API #1268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the getcwd syscall behaved according to the libc API instead of the kernel one, returning a pointer to the buffer containing the path, as well as potentially allocating memory. This change fixes this, providing the correct API: userspace is solely responsible for memory allocation, and the syscall returns the length of the output path. Signed-off-by: Andrei Tatar <andrei@unikraft.io>
github-actions
bot
added
area/lib
StefanJum
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
Works fine, thanks.
Reviewed-by: Stefan Jumarea stefanjumarea02@gmail.com
skuenzer
approved these changes
Jan 18, 2024
skuenzer
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
Great, I also checked that it works and code update looks fine. Thanks!
Approved-by: Simon Kuenzer simon@unikraft.io
razvand
pushed a commit
that referenced
this pull request
Jan 18, 2024
Previously the getcwd syscall behaved according to the libc API instead of the kernel one, returning a pointer to the buffer containing the path, as well as potentially allocating memory. This change fixes this, providing the correct API: userspace is solely responsible for memory allocation, and the syscall returns the length of the output path. Signed-off-by: Andrei Tatar <andrei@unikraft.io> Reviewed-by: Stefan Jumarea <stefanjumarea02@gmail.com> Reviewed-by: Simon Kuenzer <simon@unikraft.io> Approved-by: Simon Kuenzer <simon@unikraft.io> GitHub-Closes: #1268
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Previously the getcwd syscall behaved according to the libc API instead of the kernel one, returning a pointer to the buffer containing the path, as well as potentially allocating memory.
This change fixes this, providing the correct API: userspace is solely responsible for memory allocation, and the syscall returns the length of the output path.
Prerequisite checklist
checkpatch.ukon your commit series before opening this PR;Base target
Additional configuration
Build with vfscore enabled (e.g.,
app-elfloader). Bincompat golang will, for some PWDs, return error fromos.Getwdwithout this fix.