Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/ukboot: Silence compiler warning on envp #1378

Conversation

michpappas
Copy link
Member

@michpappas michpappas commented Apr 4, 2024

Make declaration of envp conditional to CONFIG_LIBUKDEBUG_PRINTK_INFO to silence a compiler warning on unused variable.

Prerequisite checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Ran the checkpatch.uk on your commit series before opening this PR;
  • Updated relevant documentation.

Base target

  • Architecture(s): [N/A]
  • Platform(s): [N/A]
  • Application(s): [N/A]

Additional configuration

Description of changes

Make declaration of envp conditional to CONFIG_LIBUKDEBUG_PRINTK_INFO to silence a compiler warning on unused variable.

@michpappas michpappas requested a review from a team as a code owner April 4, 2024 19:04
@github-actions github-actions bot added area/lib Internal Unikraft Microlibrary lang/c Issues or PRs to do with C/C++ lib/ukboot labels Apr 4, 2024
@michpappas michpappas force-pushed the michpappas/bugfix/ukboot_envp_warning branch from 7f1c918 to abf5c84 Compare April 5, 2024 09:58
Mark declaration of envp as __maybe_unused to silence a compiler
warning.

Signed-off-by: Michalis Pappas <michalis@unikraft.io>
@michpappas michpappas force-pushed the michpappas/bugfix/ukboot_envp_warning branch from abf5c84 to e61fd6a Compare April 5, 2024 10:02
@razvand razvand self-assigned this Apr 28, 2024
@razvand razvand requested review from RaduNichita, rares-miculescu and DeliaPavel and removed request for a team and RaduNichita April 28, 2024 05:40
@razvand razvand added this to the v0.17.0 (Calypso) milestone Apr 28, 2024
Copy link

@rares-miculescu rares-miculescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on my side.

Reviewed-by: Rares Miculescu miculescur@gmail.com

Copy link
Contributor

@DeliaPavel DeliaPavel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Reviewed-by: Delia Pavel delia_maria.pavel@stud.acs.upb.ro

Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved-by: Razvan Deaconescu razvand@unikraft.io

@razvand razvand changed the base branch from staging to staging-1378 May 21, 2024 20:46
@razvand razvand merged commit dd23b8a into unikraft:staging-1378 May 21, 2024
12 checks passed
razvand pushed a commit that referenced this pull request May 21, 2024
Mark declaration of envp as __maybe_unused to silence a compiler
warning.

Signed-off-by: Michalis Pappas <michalis@unikraft.io>
Reviewed-by: Delia Pavel <delia_maria.pavel@stud.acs.upb.ro>
Approved-by: Razvan Deaconescu <razvand@unikraft.io>
GitHub-Closes: #1378
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/lib Internal Unikraft Microlibrary lang/c Issues or PRs to do with C/C++ lib/ukboot
Projects
Status: Done!
Development

Successfully merging this pull request may close these issues.

4 participants