lib/ukboot: Silence compiler warning on envp #1378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/lib
michpappas
force-pushed
the
michpappas/bugfix/ukboot_envp_warning
branch
from
7f1c918
to
abf5c84
Compare
Mark declaration of envp as __maybe_unused to silence a compiler warning. Signed-off-by: Michalis Pappas <michalis@unikraft.io>
michpappas
force-pushed
the
michpappas/bugfix/ukboot_envp_warning
branch
from
abf5c84
to
e61fd6a
Compare
razvand
requested review from
RaduNichita,
rares-miculescu and
DeliaPavel
and removed request for
a team and
RaduNichita
rares-miculescu
approved these changes
Apr 28, 2024
There was a problem hiding this comment.
Looks good on my side.
Reviewed-by: Rares Miculescu miculescur@gmail.com
DeliaPavel
approved these changes
May 2, 2024
There was a problem hiding this comment.
Looks good.
Reviewed-by: Delia Pavel delia_maria.pavel@stud.acs.upb.ro
4 tasks
razvand
approved these changes
May 21, 2024
razvand
pushed a commit
that referenced
this pull request
May 21, 2024
Mark declaration of envp as __maybe_unused to silence a compiler warning. Signed-off-by: Michalis Pappas <michalis@unikraft.io> Reviewed-by: Delia Pavel <delia_maria.pavel@stud.acs.upb.ro> Approved-by: Razvan Deaconescu <razvand@unikraft.io> GitHub-Closes: #1378
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make declaration of envp conditional to CONFIG_LIBUKDEBUG_PRINTK_INFO to silence a compiler warning on unused variable.
Prerequisite checklist
checkpatch.ukon your commit series before opening this PR;Base target
Additional configuration
Description of changes
Make declaration of
envpconditional toCONFIG_LIBUKDEBUG_PRINTK_INFOto silence a compiler warning on unused variable.