arch/libcontext: arm64: Make TCB overlap configurable #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardvintila
force-pushed
the
update_aarch64_tls
branch
from
4689e60
to
71fb8b5
Compare
eduardvintila
force-pushed
the
update_aarch64_tls
branch
2 times, most recently
from
7e41918
to
f9213e1
Compare
kubanrob
suggested changes
Jan 19, 2023
eduardvintila
force-pushed
the
update_aarch64_tls
branch
from
f9213e1
to
4daf48c
Compare
|
Hey, @kubanrob! Thanks a lot for pointing this out! I have updated my PR accordingly. |
eduardvintila
force-pushed
the
update_aarch64_tls
branch
from
4daf48c
to
a3ae8b0
Compare
kubanrob
reviewed
Jan 30, 2023
eduardvintila
force-pushed
the
update_aarch64_tls
branch
from
a3ae8b0
to
66f0fbc
Compare
The Aarch64 ABI requires 16 bytes of space after the `tlsp` pointer as part of the TCB. However, this space is not expected by newer versions of the `musl` library. As such, this commit introduces a new Makefile rule by which a library can register whether this reserved space is not necessary. The rule sets a macro by which we can then decide to assume a 16-byte block space is reserved at the end of the TCB or not. This maintains backwards compatibility with previous versions of `musl`, since if the rule is not invoked, it is assumed that the library expects the `AARCH64_RESERVED` block of 16 bytes described by the ABI. Signed-off-by: Eduard Vintilă <eduard.vintila47@gmail.com>
eduardvintila
force-pushed
the
update_aarch64_tls
branch
from
66f0fbc
to
b807df1
Compare
|
Hey, @kubanrob. Great catch, thanks! I've updated that comment, as well. |
|
✅ Checkpatch passed Beep boop! I ran Unikraft's
|
kubanrob
approved these changes
Jan 31, 2023
There was a problem hiding this comment.
Looks good to me, thank you @eduardvintila!
Reviewed-by: Robert Kuban robert.kuban@opensynergy.com
razvand
approved these changes
Jan 31, 2023
noureddine-taleb
pushed a commit
to noureddine-taleb/unikraft
that referenced
this pull request
Mar 23, 2023
The Aarch64 ABI requires 16 bytes of space after the `tlsp` pointer as part of the TCB. However, this space is not expected by newer versions of the `musl` library. As such, this commit introduces a new Makefile rule by which a library can register whether this reserved space is not necessary. The rule sets a macro by which we can then decide to assume a 16-byte block space is reserved at the end of the TCB or not. This maintains backwards compatibility with previous versions of `musl`, since if the rule is not invoked, it is assumed that the library expects the `AARCH64_RESERVED` block of 16 bytes described by the ABI. Signed-off-by: Eduard Vintilă <eduard.vintila47@gmail.com> Reviewed-by: Robert Kuban <robert.kuban@opensynergy.com> Approved-by: Razvan Deaconescu <razvand@unikraft.io> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: unikraft#720
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite checklist
checkpatch.plon your commit series before opening this PR;Base target
aarch64]kvm]Additional configuration
Description of changes
The Aarch64 ABI requires 16 bytes of space after the
tlsppointer as part of the TCB. However, this space is not expected by newer versions of themusllibrary.As such, this PR introduces a new Makefile rule by which a library can register whether this reserved space is not necessary. The rule sets a macro by which we can then decide to assume a 16-byte block space is reserved at the end of the TCB or not.
This maintains backwards compatibility with previous versions of
musl, since if the rule is not invoked, it is assumed that the library expects theAARCH64_RESERVEDblock of 16 bytes described by the ABI.Signed-off-by: Eduard Vintilă eduard.vintila47@gmail.com