Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error in Column.pandas_dtype #256

Merged
merged 1 commit into from
Aug 5, 2020
Merged

Conversation

cosmicBboy
Copy link
Collaborator

This PR fixes the error reported in #192 where Columns had its own pandas_dtype property. This diff adds a pandas_dtype getter and setter to the SeriesSchemaBase class for consistency.

@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2020

Codecov Report

Merging #256 into master will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #256      +/-   ##
==========================================
+ Coverage   96.45%   96.55%   +0.10%     
==========================================
  Files          15       15              
  Lines        1299     1308       +9     
==========================================
+ Hits         1253     1263      +10     
+ Misses         46       45       -1     
Impacted Files Coverage Δ
pandera/schema_components.py 98.41% <100.00%> (-0.02%) ⬇️
pandera/schemas.py 96.52% <100.00%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58a8bcb...9aec645. Read the comment docs.

@cosmicBboy cosmicBboy merged commit 6e5b555 into master Aug 5, 2020
@cosmicBboy cosmicBboy deleted the feature/fix-column-dtype branch August 15, 2020 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants