Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes from flynt #325

Conversation

abyz0123
Copy link
Contributor

was pretty painless, the tests ran successfully.

image

@cosmicBboy
Copy link
Collaborator

looks good @ktroutman, thanks!

looks like there are some black formatting errors: https://travis-ci.org/github/pandera-dev/pandera/jobs/744748032#L634-L637

are you using balck auto-formatting on your IDE? If so it'll have to match the version and arguments in the precommit yaml file... otherwise I'm not sure why we're seeing this error.

@abyz0123
Copy link
Contributor Author

I do have the black hooks, but i put the flynt hooks after black so the flynt changes weren't conform to black. I changed the order of the hooks so that flynt comes before black.

since pre-commit can operate independently from the repo's dev dependencies,
it's not needed in the `environment.yml` file.
@codecov-io
Copy link

codecov-io commented Nov 21, 2020

Codecov Report

Merging #325 (a54df7d) into master (0cb9869) will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #325      +/-   ##
==========================================
+ Coverage   98.64%   98.79%   +0.14%     
==========================================
  Files          18       18              
  Lines        1702     1738      +36     
==========================================
+ Hits         1679     1717      +38     
+ Misses         23       21       -2     
Impacted Files Coverage Δ
pandera/checks.py 98.42% <ø> (ø)
pandera/decorators.py 100.00% <ø> (ø)
pandera/dtypes.py 100.00% <ø> (+2.29%) ⬆️
pandera/error_formatters.py 100.00% <ø> (ø)
pandera/hypotheses.py 92.72% <ø> (ø)
pandera/schema_statistics.py 100.00% <ø> (ø)
pandera/errors.py 100.00% <100.00%> (ø)
pandera/io.py 97.82% <100.00%> (ø)
pandera/schema_components.py 98.42% <100.00%> (+0.02%) ⬆️
pandera/schemas.py 98.12% <100.00%> (+0.14%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cb9869...a54df7d. Read the comment docs.

@cosmicBboy cosmicBboy merged commit ac41212 into unionai-oss:master Nov 22, 2020
@abyz0123 abyz0123 deleted the 273_replace_sstring_formatting_for_fstring_formatting branch November 22, 2020 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants