bugfix: coerce nullable str column handles all na #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this diff fixes an issue reported in #365 that fails to coerce nullable string column in the case that all values are null. The issue surfaces when reading a csv file when a column has all null values, since these columns will be of float dtype. We can reproduce this behavior by creating a null column in a dataframe of float type. Add tests to make sure this case is handled, along with the nullable string and integer types in pandas>1.0.0.
Closed
3 tasks
Codecov Report
@@ Coverage Diff @@
## master #366 +/- ##
=======================================
Coverage 99.21% 99.21%
=======================================
Files 21 21
Lines 2427 2427
=======================================
Hits 2408 2408
Misses 19 19
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this diff fixes an issue reported in #365 that fails to coerce
nullable string column in the case that all values are null.
The issue surfaces when reading a csv file when a column has
all null values, since these columns will be of float dtype. We
can reproduce this behavior by creating a null column in a
dataframe of float type.
Add tests to make sure this case is handled, along with the
nullable string and integer types in pandas>1.0.0.