Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom check extensions doc #975

Merged
merged 3 commits into from
Oct 21, 2022
Merged

Conversation

a-recknagel
Copy link
Contributor

@a-recknagel a-recknagel commented Oct 20, 2022

Resolves: #974

@a-recknagel
Copy link
Contributor Author

a-recknagel commented Oct 20, 2022

I don't know how to link this PR with the issue - I thought the comment up top would handle that but seems it doesn't.

@cosmicBboy cosmicBboy changed the base branch from dev to master October 20, 2022 13:19
@cosmicBboy cosmicBboy changed the title Resolves https://github.com/unionai-oss/pandera/issues/974 Fix custom check extensions doc Oct 20, 2022
@cosmicBboy
Copy link
Collaborator

thanks @a-recknagel !

@cosmicBboy
Copy link
Collaborator

I don't know how to link this PR with the issue - I thought the comment up top would handle that but seems it doesn't.

it should!

image

@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Base: 96.69% // Head: 96.69% // No change to project coverage 👍

Coverage data is based on head (4880b53) compared to base (914d493).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #975   +/-   ##
=======================================
  Coverage   96.69%   96.69%           
=======================================
  Files          42       42           
  Lines        4201     4201           
=======================================
  Hits         4062     4062           
  Misses        139      139           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cosmicBboy cosmicBboy merged commit 5e6ddb1 into unionai-oss:master Oct 21, 2022
@a-recknagel a-recknagel deleted the docs/#974 branch October 21, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong calculation and kwarg in custom check docs
2 participants