Skip to content

Update configuring-notifications.md #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update configuring-notifications.md #411

wants to merge 1 commit into from

Conversation

dwo
Copy link
Contributor

@dwo dwo commented Jul 17, 2025

Minor corrections to webhook connector example.

Minor corrections to webhook connector example
@dwo dwo requested review from nelsonjr and ppiegaze as code owners July 17, 2025 10:24
@dwo dwo marked this pull request as draft July 17, 2025 10:53
@dwo
Copy link
Contributor Author

dwo commented Jul 17, 2025

Oh, just realised that this was maybe previously corrected since you can't do try-except in workflows? https://flyte-org.slack.com/archives/CP2HDHKE1/p1749452010102699

@@ -176,7 +178,7 @@ notification_task = WebhookTask(
)
...

@fl.task
@fl.workflow
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would only work in an @eager workflow? 🤔

@ppiegaze
Copy link
Collaborator

I have transfered this PR to a branch in the docs repo and merged it there (this is necessary due to our current Cloudflare setup). I also made a correction

@ppiegaze ppiegaze closed this Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants