Run tests against a real server, not mock data #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit does the following: - Removes "playback" functionality from mocktraffic.py and renames the whole thing to a more appropriate name recordhttp.py - Changes the format of recorded output slightly, now the whole file is valid json. Updates testsuite-result.json accordingly. - Makes a few small changes to testsuite - Adds a docker-compose-file to be used when running the tests - Adds a shell script that runs the testsuite and compares output - Moves everything related to CI into a new folder - Modifies the workflow to use the aforementioned shell script
terjekv
reviewed
May 23, 2023
- Rename the file recordhttp.py to recorder.py - Change all instances of recordhttp to recorder and change the variable names to rec - Add a comment to docker-compose.yml that explains the purpose of the dummy container - Add types to the functions in recorder.py - Add comments about why compare to empty string
oyvindhagberg
force-pushed
the
test-with-real-server-2023-05
branch
from
aedb112
to
357f7ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit does the following:
mocktraffic.pyand renames the whole thing to a more appropriate namerecordhttp.pytestsuite-result.jsonaccordingly.testsuite