-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace no-cover pragmas with mocks. #506
Open
terjekv
wants to merge
4
commits into
unioslo:master
Choose a base branch
from
terjekv:coverage-fixes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+106
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oyvindkolbu
suggested changes
May 30, 2023
terjekv
force-pushed
the
coverage-fixes
branch
2 times, most recently
from
June 12, 2023 14:21
86e74a5
to
643ec1c
Compare
terjekv
force-pushed
the
coverage-fixes
branch
from
August 18, 2023 08:48
034e595
to
376f4a0
Compare
oyvindhagberg
approved these changes
Aug 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks to me like the requested changes were addressed and resolved.
terjekv
force-pushed
the
coverage-fixes
branch
from
August 28, 2023 13:36
376f4a0
to
7e2b28b
Compare
terjekv
force-pushed
the
coverage-fixes
branch
from
September 18, 2023 07:08
6dca40d
to
89bfb8f
Compare
terjekv
force-pushed
the
coverage-fixes
branch
from
November 29, 2023 13:12
89bfb8f
to
e3311c3
Compare
terjekv
force-pushed
the
coverage-fixes
branch
from
December 5, 2023 08:35
e3311c3
to
01113db
Compare
- Also set exc_info=True to ensure structlog deals with the stack trace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.