Refactoring models. #510
Merged
Refactoring models. #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Splits mreg/models.py into five distinct files in its own mreg/models/ package.
- More or less a conceptual split along purposes:
- base.py: Core models with no dependecies (plus ForwardZoneMember)
- network.py: Network related models
- zone.py: Forward- and reverse-related models.
- host.py: Host-related models, excluding RRs.
- resource_records.py: Models for resource records.
Note that this also updates the inital migration due to ZoneHelpers being moved.
- Note that this was only picked up by the mreg-cli tests. This `WARNING: : GET "http://127.0.0.1:8000/api/v1/permissions/netgroupregex/": 500: Internal Server Error` with the state from https://github.com/unioslo/mreg/actions/runs/5314501630/jobs/9621884141?pr=510#step:7:4680 is not picked up by any other tests we currently have.
oyvindhagberg
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this also updates the inital migration due to ZoneHelpers being moved.
Fixes #512.